You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/11/01 00:33:11 UTC
[GitHub] [dubbo] AlbumenJ commented on a diff in pull request #10855: bugfix: meatadata service support read dubbo:protocol
AlbumenJ commented on code in PR #10855:
URL: https://github.com/apache/dubbo/pull/10855#discussion_r1009976413
##########
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/metadata/ConfigurableMetadataServiceExporter.java:
##########
@@ -113,7 +117,8 @@ private ProtocolConfig generateMetadataProtocol() {
ProtocolConfig protocolConfig = new ProtocolConfig();
protocolConfig.setName(specifiedProtocol);
-
+ String serialization = getSerialization(specifiedProtocol);
+ protocolConfig.setSerialization(serialization);
Review Comment:
BTW, please add some uts to verify this
##########
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/metadata/ConfigurableMetadataServiceExporter.java:
##########
@@ -113,7 +117,8 @@ private ProtocolConfig generateMetadataProtocol() {
ProtocolConfig protocolConfig = new ProtocolConfig();
protocolConfig.setName(specifiedProtocol);
-
+ String serialization = getSerialization(specifiedProtocol);
+ protocolConfig.setSerialization(serialization);
Review Comment:
Maybe we can merge all of the config from exist protocol config, or directly reuse(if user do not specify different port).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org