You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Vamsee Yarlagadda <va...@cloudera.com> on 2014/05/23 22:36:38 UTC
Review Request 21877: SENTRY-230: e2e test for doc level security to cover
failure scenarios around Index level auth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21877/
-----------------------------------------------------------
Review request for sentry and Gregory Chanan.
Bugs: SENTRY-230
https://issues.apache.org/jira/browse/SENTRY-230
Repository: sentry
Description
-------
Sentry tests should include failure scenarios for cases where a user who has doc level permissions on a collection but has no index level permissions to access the collection.
Cases covered:
User w/ doc permissions set + w/o Index level permissions -> QUERY FAIL
User w/o doc permissions + w/o index level permissions -> QUERY FAIL
Diffs
-----
sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestDocLevelOperations.java 31ecd5b685e61fb260a9335e751121a3a3f700d5
sentry-tests/sentry-tests-solr/src/test/resources/solr/sentry/test-authz-provider.ini 96ab0d456ce4003b18c4ad4c779ebdaca4a9acfc
Diff: https://reviews.apache.org/r/21877/diff/
Testing
-------
Ran the e2e tests
Thanks,
Vamsee Yarlagadda
Re: Review Request 21877: SENTRY-230: e2e test for doc level security to
cover failure scenarios around Index level auth
Posted by Gregory Chanan <gc...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21877/#review43874
-----------------------------------------------------------
sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestDocLevelOperations.java
<https://reviews.apache.org/r/21877/#comment78152>
I wouldn't really be sure from the name what this param means.
Maybe have two booleans -- runJunitQueryChecks and runAdminQueryChecks?
and if you want, a function that just takes the collection and passes true for both.
- Gregory Chanan
On May 23, 2014, 8:36 p.m., Vamsee Yarlagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21877/
> -----------------------------------------------------------
>
> (Updated May 23, 2014, 8:36 p.m.)
>
>
> Review request for sentry and Gregory Chanan.
>
>
> Bugs: SENTRY-230
> https://issues.apache.org/jira/browse/SENTRY-230
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sentry tests should include failure scenarios for cases where a user who has doc level permissions on a collection but has no index level permissions to access the collection.
>
> Cases covered:
> User w/ doc permissions set + w/o Index level permissions -> QUERY FAIL
> User w/o doc permissions + w/o index level permissions -> QUERY FAIL
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestDocLevelOperations.java 31ecd5b685e61fb260a9335e751121a3a3f700d5
> sentry-tests/sentry-tests-solr/src/test/resources/solr/sentry/test-authz-provider.ini 96ab0d456ce4003b18c4ad4c779ebdaca4a9acfc
>
> Diff: https://reviews.apache.org/r/21877/diff/
>
>
> Testing
> -------
>
> Ran the e2e tests
>
>
> Thanks,
>
> Vamsee Yarlagadda
>
>
Re: Review Request 21877: SENTRY-230: e2e test for doc level security to
cover failure scenarios around Index level auth
Posted by Gregory Chanan <gc...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21877/#review43878
-----------------------------------------------------------
Ship it!
Ship It!
- Gregory Chanan
On May 23, 2014, 8:59 p.m., Vamsee Yarlagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21877/
> -----------------------------------------------------------
>
> (Updated May 23, 2014, 8:59 p.m.)
>
>
> Review request for sentry and Gregory Chanan.
>
>
> Bugs: SENTRY-230
> https://issues.apache.org/jira/browse/SENTRY-230
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sentry tests should include failure scenarios for cases where a user who has doc level permissions on a collection but has no index level permissions to access the collection.
>
> Cases covered:
> User w/ doc permissions set + w/o Index level permissions -> QUERY FAIL
> User w/o doc permissions + w/o index level permissions -> QUERY FAIL
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestDocLevelOperations.java 31ecd5b685e61fb260a9335e751121a3a3f700d5
> sentry-tests/sentry-tests-solr/src/test/resources/solr/sentry/test-authz-provider.ini 96ab0d456ce4003b18c4ad4c779ebdaca4a9acfc
>
> Diff: https://reviews.apache.org/r/21877/diff/
>
>
> Testing
> -------
>
> Ran the e2e tests
>
>
> Thanks,
>
> Vamsee Yarlagadda
>
>
Re: Review Request 21877: SENTRY-230: e2e test for doc level security to
cover failure scenarios around Index level auth
Posted by Vamsee Yarlagadda <va...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21877/
-----------------------------------------------------------
(Updated May 23, 2014, 8:59 p.m.)
Review request for sentry and Gregory Chanan.
Changes
-------
Addressed Greg's comments.
Renamed runAllQueryChecks -> checkNonAdminUsers
Bugs: SENTRY-230
https://issues.apache.org/jira/browse/SENTRY-230
Repository: sentry
Description
-------
Sentry tests should include failure scenarios for cases where a user who has doc level permissions on a collection but has no index level permissions to access the collection.
Cases covered:
User w/ doc permissions set + w/o Index level permissions -> QUERY FAIL
User w/o doc permissions + w/o index level permissions -> QUERY FAIL
Diffs (updated)
-----
sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestDocLevelOperations.java 31ecd5b685e61fb260a9335e751121a3a3f700d5
sentry-tests/sentry-tests-solr/src/test/resources/solr/sentry/test-authz-provider.ini 96ab0d456ce4003b18c4ad4c779ebdaca4a9acfc
Diff: https://reviews.apache.org/r/21877/diff/
Testing
-------
Ran the e2e tests
Thanks,
Vamsee Yarlagadda