[GitHub] [jackrabbit-filevault] kwin commented on a diff in pull request #245: JCRVLT-658: Importer fails for invalid namespace names

[GitBox <gi...@apache.org>]

kwin commented on code in PR #245:
URL: https://github.com/apache/jackrabbit-filevault/pull/245#discussion_r979253264


##########
vault-core/src/test/resources/test-packages/badnamespacenames.zip/META-INF/vault/config.xml:
##########
@@ -0,0 +1,93 @@
+<!--

Review Comment:
   file is default and not necessary



##########
vault-core/src/test/resources/test-packages/badnamespacenames.zip/META-INF/vault/definition/.content.xml:
##########
@@ -0,0 +1,25 @@
+<?xml version="1.0" encoding="UTF-8"?>

Review Comment:
   file is not necessary



##########
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewImporter.java:
##########
@@ -1200,28 +1200,37 @@ private boolean isPropertyProtected(@NotNull EffectiveNodeType effectiveNodeType
         return effectiveNodeType.getApplicablePropertyDefinition(npResolver.getJCRName(docViewProperty.getName()), docViewProperty.isMultiValue(), docViewProperty.getType()).map(PropertyDefinition::isProtected).orElse(false);
     }
 
+    private String nameToPathComponent(Name name) throws RepositoryException {

Review Comment:
   maybe `getLexicalForm` as method name (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/3_Repository_Model.html#3.2.5%20Lexical%20Form%20of%20JCR%20Names) which would allow both expanded and qualified form.



##########
vault-core/src/test/resources/test-packages/badnamespacenames.zip/META-INF/vault/nodetypes.cnd:
##########
@@ -0,0 +1,17 @@
+<'vlt'='http://www.day.com/jcr/vault/1.0'>

Review Comment:
   file is not necessary



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org