You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/05/30 18:20:54 UTC
[GitHub] [cloudstack] nvazquez opened a new pull request, #6423: Fix UEFI detection on KVM and prevent deployments on non UEFI enabled hosts
nvazquez opened a new pull request, #6423:
URL: https://github.com/apache/cloudstack/pull/6423
### Description
This PR fixes 2 issues:
- Prevent UEFI deployments on non UEFI enabled hosts (do not assume the host detail will always be present in case of not enabled)
- Fix the UEFI detection on KVM (uefi.properties file was missing)
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Tested on KVM - one UEFI enabled host, one disabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6423: Fix UEFI detection on KVM and prevent deployments on non UEFI enabled hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6423:
URL: https://github.com/apache/cloudstack/pull/6423#issuecomment-1141994385
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6423: Fix UEFI detection on KVM and prevent deployments on non UEFI enabled hosts
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6423:
URL: https://github.com/apache/cloudstack/pull/6423#issuecomment-1141926763
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6423: Fix UEFI detection on KVM and prevent deployments on non UEFI enabled hosts
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6423:
URL: https://github.com/apache/cloudstack/pull/6423#issuecomment-1141430290
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6423)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6423&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6423&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6423&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6423&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6423&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6423&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6423&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6423&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6423&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6423&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6423&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6423&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6423&metric=new_coverage&view=list) [20.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6423&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6423&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6423&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a diff in pull request #6423: Fix UEFI detection on KVM and prevent deployments on non UEFI enabled hosts
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on code in PR #6423:
URL: https://github.com/apache/cloudstack/pull/6423#discussion_r885303169
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -1414,6 +1414,10 @@ private void configureAgentHooks(final Map<String, Object> params) {
s_logger.debug("agent.hooks.libvirt_vm_on_stop.method is " + _agentHooksVmOnStopMethod);
}
+ public boolean isUefiPropertiesFileSet() {
Review Comment:
@nvazquez UEFI properties are loaded from this file while configuring the resource, no need to check again for this file, instead check for properties loaded or not. Also, re-use this method in _loadUefiProperties()_ method below for the same condition. Thanks.
```suggestion
public boolean isUefiPropertiesLoaded() {
return _uefiProperties != null && _uefiProperties.getProperty("guest.loader.legacy") != null
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6423: Fix UEFI detection on KVM and prevent deployments on non UEFI enabled hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6423:
URL: https://github.com/apache/cloudstack/pull/6423#issuecomment-1141993494
@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #6423: Fix UEFI detection on KVM and prevent deployments on non UEFI enabled hosts
Posted by GitBox <gi...@apache.org>.
nvazquez merged PR #6423:
URL: https://github.com/apache/cloudstack/pull/6423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6423: Fix UEFI detection on KVM and prevent deployments on non UEFI enabled hosts
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6423:
URL: https://github.com/apache/cloudstack/pull/6423#issuecomment-1141945273
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6423: Fix UEFI detection on KVM and prevent deployments on non UEFI enabled hosts
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6423:
URL: https://github.com/apache/cloudstack/pull/6423#issuecomment-1141406379
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6423: Fix UEFI detection on KVM and prevent deployments on non UEFI enabled hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6423:
URL: https://github.com/apache/cloudstack/pull/6423#issuecomment-1141932041
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6423 (SL-JID-1643)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6423: Fix UEFI detection on KVM and prevent deployments on non UEFI enabled hosts
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6423:
URL: https://github.com/apache/cloudstack/pull/6423#issuecomment-1141993590
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6423: Fix UEFI detection on KVM and prevent deployments on non UEFI enabled hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6423:
URL: https://github.com/apache/cloudstack/pull/6423#issuecomment-1141945887
@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6423: Fix UEFI detection on KVM and prevent deployments on non UEFI enabled hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6423:
URL: https://github.com/apache/cloudstack/pull/6423#issuecomment-1141926845
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6423: Fix UEFI detection on KVM and prevent deployments on non UEFI enabled hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6423:
URL: https://github.com/apache/cloudstack/pull/6423#issuecomment-1142006205
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6423 (SL-JID-1645)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6423: Fix UEFI detection on KVM and prevent deployments on non UEFI enabled hosts
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6423:
URL: https://github.com/apache/cloudstack/pull/6423#issuecomment-1141996452
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6423: Fix UEFI detection on KVM and prevent deployments on non UEFI enabled hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6423:
URL: https://github.com/apache/cloudstack/pull/6423#issuecomment-1141997244
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6423: Fix UEFI detection on KVM and prevent deployments on non UEFI enabled hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6423:
URL: https://github.com/apache/cloudstack/pull/6423#issuecomment-1141426597
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6423: Fix UEFI detection on KVM and prevent deployments on non UEFI enabled hosts
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6423:
URL: https://github.com/apache/cloudstack/pull/6423#issuecomment-1141543117
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6423: Fix UEFI detection on KVM and prevent deployments on non UEFI enabled hosts
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6423:
URL: https://github.com/apache/cloudstack/pull/6423#issuecomment-1141987398
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6423)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6423&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6423&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6423&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6423&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6423&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6423&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6423&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6423&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6423&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6423&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6423&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6423&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6423&metric=new_coverage&view=list) [12.1% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6423&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6423&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6423&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6423: Fix UEFI detection on KVM and prevent deployments on non UEFI enabled hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6423:
URL: https://github.com/apache/cloudstack/pull/6423#issuecomment-1141406914
@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6423: Fix UEFI detection on KVM and prevent deployments on non UEFI enabled hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6423:
URL: https://github.com/apache/cloudstack/pull/6423#issuecomment-1141982876
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6423: Fix UEFI detection on KVM and prevent deployments on non UEFI enabled hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6423:
URL: https://github.com/apache/cloudstack/pull/6423#issuecomment-1142003826
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6423 (SL-JID-1644)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6423: Fix UEFI detection on KVM and prevent deployments on non UEFI enabled hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6423:
URL: https://github.com/apache/cloudstack/pull/6423#issuecomment-1141543311
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6423: Fix UEFI detection on KVM and prevent deployments on non UEFI enabled hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6423:
URL: https://github.com/apache/cloudstack/pull/6423#issuecomment-1142037920
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6423: Fix UEFI detection on KVM and prevent deployments on non UEFI enabled hosts
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6423:
URL: https://github.com/apache/cloudstack/pull/6423#issuecomment-1141403192
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a diff in pull request #6423: Fix UEFI detection on KVM and prevent deployments on non UEFI enabled hosts
Posted by GitBox <gi...@apache.org>.
nvazquez commented on code in PR #6423:
URL: https://github.com/apache/cloudstack/pull/6423#discussion_r885507057
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -1414,6 +1414,10 @@ private void configureAgentHooks(final Map<String, Object> params) {
s_logger.debug("agent.hooks.libvirt_vm_on_stop.method is " + _agentHooksVmOnStopMethod);
}
+ public boolean isUefiPropertiesFileSet() {
Review Comment:
Have actually simplified the check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6423: Fix UEFI detection on KVM and prevent deployments on non UEFI enabled hosts
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6423:
URL: https://github.com/apache/cloudstack/pull/6423#issuecomment-1141992377
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6423: Fix UEFI detection on KVM and prevent deployments on non UEFI enabled hosts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6423:
URL: https://github.com/apache/cloudstack/pull/6423#issuecomment-1142008170
<b>Trillian test result (tid-4266)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40729 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6423-t4266-kvm-centos7.zip
Smoke tests completed. 86 look OK, 11 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_DeployVmAffinityGroup | `Error` | 1.17 | test_affinity_groups.py
test_DeployVmAntiAffinityGroup | `Error` | 1.14 | test_affinity_groups.py
ContextSuite context=TestDeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
test_01_secure_vm_migration | `Error` | 0.01 | test_vm_life_cycle.py
test_02_unsecure_vm_migration | `Error` | 0.01 | test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration | `Error` | 0.01 | test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration | `Error` | 0.01 | test_vm_life_cycle.py
ContextSuite context=TestVMLifeCycle>:setup | `Error` | 2.67 | test_vm_life_cycle.py
ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | test_affinity_groups_projects.py
test_01_snapshot_root_disk | `Error` | 907.68 | test_snapshots.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
test_01_nic | `Error` | 51.42 | test_nic.py
ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVpnUsage>:setup | `Error` | 0.00 | test_usage.py
test_09_project_suspend | `Error` | 1.07 | test_projects.py
test_10_project_activation | `Error` | 1.06 | test_projects.py
ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
test_01_cancel_host_maintenace_with_no_migration_jobs | `Error` | 0.04 | test_host_maintenance.py
test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 0.04 | test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failure | `Error` | 0.04 | test_host_maintenance.py
test_01_cancel_host_maintenance_ssh_enabled_agent_connected | `Error` | 0.01 | test_host_maintenance.py
test_03_cancel_host_maintenance_ssh_disabled_agent_connected | `Error` | 0.01 | test_host_maintenance.py
test_04_cancel_host_maintenance_ssh_disabled_agent_disconnected | `Error` | 0.01 | test_host_maintenance.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a diff in pull request #6423: Fix UEFI detection on KVM and prevent deployments on non UEFI enabled hosts
Posted by GitBox <gi...@apache.org>.
nvazquez commented on code in PR #6423:
URL: https://github.com/apache/cloudstack/pull/6423#discussion_r885443193
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -1414,6 +1414,10 @@ private void configureAgentHooks(final Map<String, Object> params) {
s_logger.debug("agent.hooks.libvirt_vm_on_stop.method is " + _agentHooksVmOnStopMethod);
}
+ public boolean isUefiPropertiesFileSet() {
Review Comment:
Done, thanks - nice catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6423: Fix UEFI detection on KVM and prevent deployments on non UEFI enabled hosts
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6423:
URL: https://github.com/apache/cloudstack/pull/6423#issuecomment-1141926613
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6423: Fix UEFI detection on KVM and prevent deployments on non UEFI enabled hosts
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6423:
URL: https://github.com/apache/cloudstack/pull/6423#issuecomment-1142044675
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6423)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6423&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6423&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6423&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6423&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6423&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6423&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6423&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6423&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6423&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6423&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6423&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6423&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6423&metric=new_coverage&view=list) [12.9% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6423&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6423&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6423&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org