[GitHub] [kafka] cmccabe commented on pull request #10019: MINOR: Introduce KafkaBroker trait for use in dynamic reconfiguration

[GitBox <gi...@apache.org>]

cmccabe commented on pull request #10019:
URL: https://github.com/apache/kafka/pull/10019#issuecomment-772706382


   I agree with the comments from earlier that we don't want to expose the pre-KIP-500 `KafkaController` in the `KafkaServer` interface.  I think casting to `KafkaServer` or `RaftBrokerServer` is a reasonable solution.  It fits with the general (anti?) pattern in `DynamicBrokerConfig` of reaching directly into broker fields to do stuff.  Arguably a lot of this code should be in the broker class itself for just that reason, so that these broker fields can be private. But, one step at a time.
   
   We should disallow changing broker listener configurations if KIP-500 is enabled, until we implement re-registering the broker.  (This isn't a lot of work but we just haven't done it yet...)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org