You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/05/11 14:08:58 UTC
[GitHub] [dolphinscheduler] wuchunfu opened a new pull request, #10000: [Feature][CI] Add Dead Link Checker
wuchunfu opened a new pull request, #10000:
URL: https://github.com/apache/dolphinscheduler/pull/10000
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
## Purpose of the pull request
close #9999
<!--(For example: This pull request adds checkstyle plugin).-->
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] devosend commented on pull request #10000: [Feature][CI] Add Dead Link Checker
Posted by GitBox <gi...@apache.org>.
devosend commented on PR #10000:
URL: https://github.com/apache/dolphinscheduler/pull/10000#issuecomment-1158440862
This pr should be cherry-pick to milestone 3.0.0-beta-2? @zhongjiajie @wuchunfu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #10000: [Feature][CI] Add Dead Link Checker
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #10000:
URL: https://github.com/apache/dolphinscheduler/pull/10000#issuecomment-1129848021
I rerun the failed CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10000: [Feature][CI] Add Dead Link Checker
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10000:
URL: https://github.com/apache/dolphinscheduler/pull/10000#issuecomment-1127509956
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10000)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10000&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10000&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10000&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10000&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10000&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10000&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10000&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10000&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10000&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10000&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10000&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10000&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10000&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10000&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #10000: [Feature][CI] Add Dead Link Checker
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #10000:
URL: https://github.com/apache/dolphinscheduler/pull/10000#discussion_r873275429
##########
.github/workflows/dead-link-checker.yaml:
##########
@@ -0,0 +1,40 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Dead Link Checker
+
+on:
+ pull_request:
+ schedule:
+ - cron: '0 18 * * *' # TimeZone: UTC 0
Review Comment:
Hi @wuchunfu , maybe we should add this setting or others setting we miss into `docs.yaml` CI configuration. WDYT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on pull request #10000: [Feature][CI] Add Dead Link Checker
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on PR #10000:
URL: https://github.com/apache/dolphinscheduler/pull/10000#issuecomment-1158450635
> This pr should be cherry-pick to milestone 3.0.0-beta-2? @zhongjiajie @wuchunfu
This is just CI settings, not functionality related, I think we don't need to back port this to previous version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] devosend commented on pull request #10000: [Feature][CI] Add Dead Link Checker
Posted by GitBox <gi...@apache.org>.
devosend commented on PR #10000:
URL: https://github.com/apache/dolphinscheduler/pull/10000#issuecomment-1158463964
> > This pr should be cherry-pick to milestone 3.0.0-beta-2? @zhongjiajie @wuchunfu
>
> This is just CI settings, not functionality related, I think we don't need to back port this to previous version.
But is will affect cherry-pick of #10325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] wuchunfu commented on pull request #10000: [Feature][CI] Add Dead Link Checker
Posted by GitBox <gi...@apache.org>.
wuchunfu commented on PR #10000:
URL: https://github.com/apache/dolphinscheduler/pull/10000#issuecomment-1126948464
> But we already have the dead link checker in our docs.yaml https://github.com/apache/dolphinscheduler/blob/dev/.github/workflows/docs.yml#L48-L60 what the difference is? and could we combine them?
Well, close it if you don't need my contribution this time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10000: [Feature][CI] Add Dead Link Checker
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10000:
URL: https://github.com/apache/dolphinscheduler/pull/10000#issuecomment-1123852107
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10000)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10000&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10000&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10000&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10000&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10000&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10000&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10000&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10000&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10000&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10000&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10000&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10000&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10000&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10000&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] wuchunfu commented on pull request #10000: [Feature][CI] Add Dead Link Checker
Posted by GitBox <gi...@apache.org>.
wuchunfu commented on PR #10000:
URL: https://github.com/apache/dolphinscheduler/pull/10000#issuecomment-1125057778
> Please handle the dead link pngs
I don't know what those two pngs are, can anyone help me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] dailidong commented on pull request #10000: [Feature][CI] Add Dead Link Checker
Posted by GitBox <gi...@apache.org>.
dailidong commented on PR #10000:
URL: https://github.com/apache/dolphinscheduler/pull/10000#issuecomment-1124737748
Please handle the dead link pngs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #10000: [Feature][CI] Add Dead Link Checker
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #10000:
URL: https://github.com/apache/dolphinscheduler/pull/10000#issuecomment-1126933790
But we already have the dead link checker in our docs.yaml https://github.com/apache/dolphinscheduler/blob/dev/.github/workflows/docs.yml#L48-L60 what the difference is? and could we combine them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #10000: [Feature][CI] Add Dead Link Checker
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #10000:
URL: https://github.com/apache/dolphinscheduler/pull/10000#issuecomment-1158509876
> > > > This pr should be cherry-pick to milestone 3.0.0-beta-2? @zhongjiajie @wuchunfu
> > >
> > >
> > > This is just CI settings, not functionality related, I think we don't need to back port this to previous version.
> >
> >
> > But is will affect cherry-pick of #10325
>
> OK if that's the case, you can cherry pick this. It's not functionality related so you can choose to or not to cherry pick it, if other depends on this you can do it
Agrees with that we can or can not cherry pick this to nest release branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] wuchunfu commented on a diff in pull request #10000: [Feature][CI] Add Dead Link Checker
Posted by GitBox <gi...@apache.org>.
wuchunfu commented on code in PR #10000:
URL: https://github.com/apache/dolphinscheduler/pull/10000#discussion_r873541384
##########
.github/workflows/dead-link-checker.yaml:
##########
@@ -0,0 +1,40 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Dead Link Checker
+
+on:
+ pull_request:
+ schedule:
+ - cron: '0 18 * * *' # TimeZone: UTC 0
Review Comment:
Thanks jiajie for the review, I'll finish it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 merged pull request #10000: [Feature][CI] Add Dead Link Checker
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged PR #10000:
URL: https://github.com/apache/dolphinscheduler/pull/10000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #10000: [Feature][CI] Add Dead Link Checker
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #10000:
URL: https://github.com/apache/dolphinscheduler/pull/10000#issuecomment-1131420281
Restarted it again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on pull request #10000: [Feature][CI] Add Dead Link Checker
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on PR #10000:
URL: https://github.com/apache/dolphinscheduler/pull/10000#issuecomment-1158486885
> > > This pr should be cherry-pick to milestone 3.0.0-beta-2? @zhongjiajie @wuchunfu
> >
> >
> > This is just CI settings, not functionality related, I think we don't need to back port this to previous version.
>
> But is will affect cherry-pick of #10325
OK if that's the case, you can cherry pick this. It's not functionality related so you can choose to or not to cherry pick it, if other depends on this you can do it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org