You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tamas Mate (Code Review)" <ge...@cloudera.org> on 2022/08/31 14:16:26 UTC
[Impala-ASF-CR] IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test ctas
Tamas Mate has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18933
Change subject: IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test_ctas
......................................................................
IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test_ctas
TestAsyncDDLTiming.test_ctas is likely to be flaky, additionally it
throws AttributeError when fails which hides the details of the failure.
This commit fixes the AttributeError which is caused by the Impyla tests,
the Impyla handler is a HiveServer2Cursor object that does not have an
'id' attribute. Query string can be printed instead of the query id.
Testing:
- Triggered test failure manually and verified the result.
Change-Id: Ibe78b3a3ee070a1edeaef5cf7ae8d9565a10141d
---
M tests/common/impala_test_suite.py
1 file changed, 23 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/18933/1
--
To view, visit http://gerrit.cloudera.org:8080/18933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe78b3a3ee070a1edeaef5cf7ae8d9565a10141d
Gerrit-Change-Number: 18933
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
[Impala-ASF-CR] IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test ctas
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/18933 )
Change subject: IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test_ctas
......................................................................
IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test_ctas
TestAsyncDDLTiming.test_ctas is likely to be flaky, additionally it
throws AttributeError when fails which hides the details of the failure.
This commit fixes the AttributeError which is caused by the Impyla tests,
the Impyla handler is a HiveServer2Cursor object that does not have an
'id' attribute. Query string can be printed instead of the query id.
Testing:
- Triggered test failure manually and verified the result.
Change-Id: Ibe78b3a3ee070a1edeaef5cf7ae8d9565a10141d
---
M tests/common/impala_test_suite.py
1 file changed, 20 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/18933/3
--
To view, visit http://gerrit.cloudera.org:8080/18933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibe78b3a3ee070a1edeaef5cf7ae8d9565a10141d
Gerrit-Change-Number: 18933
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
[Impala-ASF-CR] IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test ctas
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18933 )
Change subject: IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test_ctas
......................................................................
IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test_ctas
TestAsyncDDLTiming.test_ctas is likely to be flaky, additionally it
throws AttributeError when fails which hides the details of the failure.
This commit fixes the AttributeError which is caused by the Impyla tests,
the Impyla handler is a HiveServer2Cursor object that does not have an
'id' attribute. Query string can be printed instead of the query id.
Testing:
- Triggered test failure manually and verified the result.
Change-Id: Ibe78b3a3ee070a1edeaef5cf7ae8d9565a10141d
Reviewed-on: http://gerrit.cloudera.org:8080/18933
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/common/impala_test_suite.py
1 file changed, 20 insertions(+), 6 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe78b3a3ee070a1edeaef5cf7ae8d9565a10141d
Gerrit-Change-Number: 18933
Gerrit-PatchSet: 5
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
[Impala-ASF-CR] IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test ctas
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18933 )
Change subject: IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test_ctas
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8537/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe78b3a3ee070a1edeaef5cf7ae8d9565a10141d
Gerrit-Change-Number: 18933
Gerrit-PatchSet: 4
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Wed, 07 Sep 2022 07:33:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test ctas
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/18933 )
Change subject: IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test_ctas
......................................................................
IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test_ctas
TestAsyncDDLTiming.test_ctas is likely to be flaky, additionally it
throws AttributeError when fails which hides the details of the failure.
This commit fixes the AttributeError which is caused by the Impyla tests,
the Impyla handler is a HiveServer2Cursor object that does not have an
'id' attribute. Query string can be printed instead of the query id.
Testing:
- Triggered test failure manually and verified the result.
Change-Id: Ibe78b3a3ee070a1edeaef5cf7ae8d9565a10141d
---
M tests/common/impala_test_suite.py
1 file changed, 18 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/18933/2
--
To view, visit http://gerrit.cloudera.org:8080/18933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibe78b3a3ee070a1edeaef5cf7ae8d9565a10141d
Gerrit-Change-Number: 18933
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
[Impala-ASF-CR] IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test ctas
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18933 )
Change subject: IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test_ctas
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe78b3a3ee070a1edeaef5cf7ae8d9565a10141d
Gerrit-Change-Number: 18933
Gerrit-PatchSet: 4
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Wed, 07 Sep 2022 12:20:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test ctas
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18933 )
Change subject: IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test_ctas
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe78b3a3ee070a1edeaef5cf7ae8d9565a10141d
Gerrit-Change-Number: 18933
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Tue, 06 Sep 2022 09:13:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test ctas
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18933 )
Change subject: IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test_ctas
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe78b3a3ee070a1edeaef5cf7ae8d9565a10141d
Gerrit-Change-Number: 18933
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Tue, 06 Sep 2022 23:01:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test ctas
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18933 )
Change subject: IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test_ctas
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe78b3a3ee070a1edeaef5cf7ae8d9565a10141d
Gerrit-Change-Number: 18933
Gerrit-PatchSet: 4
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Wed, 07 Sep 2022 07:33:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test ctas
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18933 )
Change subject: IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test_ctas
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11296/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe78b3a3ee070a1edeaef5cf7ae8d9565a10141d
Gerrit-Change-Number: 18933
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Tue, 06 Sep 2022 08:41:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test ctas
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18933 )
Change subject: IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test_ctas
......................................................................
Patch Set 2:
(2 comments)
Thank you for the review Quanlong, Csaba. Updated the patch.
http://gerrit.cloudera.org:8080/#/c/18933/2/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:
http://gerrit.cloudera.org:8080/#/c/18933/2/tests/common/impala_test_suite.py@1151
PS2, Line 1151: _last_operation_string
> nit: It seems better to use query_string() instead of the internal field "_
Done
http://gerrit.cloudera.org:8080/#/c/18933/2/tests/common/impala_test_suite.py@1152
PS2, Line 1152: else:
> nit: might be safer to check hasattr(handle.get_handle(), 'id'): as well
Done
--
To view, visit http://gerrit.cloudera.org:8080/18933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe78b3a3ee070a1edeaef5cf7ae8d9565a10141d
Gerrit-Change-Number: 18933
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Tue, 06 Sep 2022 12:00:32 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test ctas
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18933 )
Change subject: IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test_ctas
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11270/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe78b3a3ee070a1edeaef5cf7ae8d9565a10141d
Gerrit-Change-Number: 18933
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Aug 2022 14:38:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test ctas
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18933 )
Change subject: IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test_ctas
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18933/1/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:
http://gerrit.cloudera.org:8080/#/c/18933/1/tests/common/impala_test_suite.py@1118
PS1, Line 1118: Impyla handle
Do you know what kind of other handles can we see here?
http://gerrit.cloudera.org:8080/#/c/18933/1/tests/common/impala_test_suite.py@1122
PS1, Line 1122: if isinstance(handle.get_handle(), HiveServer2Cursor):
: timeout_msg = timeout_msg.format(handle.get_handle()._last_operation_string,
: expected_states, actual_state)
: else:
: timeout_msg = timeout_msg.format(handle.get_handle().id, expected_states,
: actual_state)
Can you put this logic somehow in a separate function? e.g. get_id_or_query_from_handle()
--
To view, visit http://gerrit.cloudera.org:8080/18933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe78b3a3ee070a1edeaef5cf7ae8d9565a10141d
Gerrit-Change-Number: 18933
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Aug 2022 14:26:49 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test ctas
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18933 )
Change subject: IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test_ctas
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11299/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe78b3a3ee070a1edeaef5cf7ae8d9565a10141d
Gerrit-Change-Number: 18933
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Tue, 06 Sep 2022 12:15:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test ctas
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18933 )
Change subject: IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test_ctas
......................................................................
Patch Set 1:
(2 comments)
Thank you for the review Csaba, updated the change.
http://gerrit.cloudera.org:8080/#/c/18933/1/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:
http://gerrit.cloudera.org:8080/#/c/18933/1/tests/common/impala_test_suite.py@1118
PS1, Line 1118: Impyla handle
> Do you know what kind of other handles can we see here?
Yes, it is a QueryHandle object described in thrift returned by the BeeswaxService thrift service:
https://github.com/apache/impala/blob/master/common/thrift/beeswax.thrift#L127
http://gerrit.cloudera.org:8080/#/c/18933/1/tests/common/impala_test_suite.py@1122
PS1, Line 1122: if isinstance(handle.get_handle(), HiveServer2Cursor):
: timeout_msg = timeout_msg.format(handle.get_handle()._last_operation_string,
: expected_states, actual_state)
: else:
: timeout_msg = timeout_msg.format(handle.get_handle().id, expected_states,
: actual_state)
> Can you put this logic somehow in a separate function? e.g. get_id_or_query
Done
--
To view, visit http://gerrit.cloudera.org:8080/18933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe78b3a3ee070a1edeaef5cf7ae8d9565a10141d
Gerrit-Change-Number: 18933
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Tue, 06 Sep 2022 08:18:06 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test ctas
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18933 )
Change subject: IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test_ctas
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18933/2/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:
http://gerrit.cloudera.org:8080/#/c/18933/2/tests/common/impala_test_suite.py@1151
PS2, Line 1151: _last_operation_string
nit: It seems better to use query_string() instead of the internal field "_last_operation_string":
https://github.com/cloudera/impyla/blob/4a75a76d8f4c761ec9efd08c918426317b588a4c/impala/hiveserver2.py#L230-L231
http://gerrit.cloudera.org:8080/#/c/18933/2/tests/common/impala_test_suite.py@1152
PS2, Line 1152: else:
nit: might be safer to check hasattr(handle.get_handle(), 'id'): as well
--
To view, visit http://gerrit.cloudera.org:8080/18933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe78b3a3ee070a1edeaef5cf7ae8d9565a10141d
Gerrit-Change-Number: 18933
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Tue, 06 Sep 2022 08:46:05 +0000
Gerrit-HasComments: Yes