[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #5920: [TE] only merge same trend in ChildKeepingMerge

[GitBox <gi...@apache.org>]

jihaozh commented on a change in pull request #5920:
URL: https://github.com/apache/incubator-pinot/pull/5920#discussion_r477664239



##########
File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/wrapper/ChildKeepingMergeWrapper.java
##########
@@ -91,10 +93,13 @@ public ChildKeepingMergeWrapper(DataProvider provider, DetectionConfigDTO config
       if (anomaly.getProperties().containsKey(PROP_GROUP_KEY)) {
         groupKey = anomaly.getProperties().get(PROP_GROUP_KEY);
       }
-
+      String patternKey = "";
+      if (anomaly.getProperties().containsKey(PROP_PATTERN_KEY)) {
+        patternKey = anomaly.getProperties().get(PROP_PATTERN_KEY);

Review comment:
       some anomalies don't have the pattern key. in that case, should it be deducted from the current and the baseline?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org