You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/04/21 22:54:29 UTC

[GitHub] [trafficserver] shinrich opened a new pull request #6697: Increase the default max_record_entries to match the original value

shinrich opened a new pull request #6697:
URL: https://github.com/apache/trafficserver/pull/6697


   Addresses issue #6472.  We've updated our /etc/sysconfig/trafficserver to pass in the 2500 (the previous compiled in value).  But if you start traffic_server without that value in our environment you get a mysterious core dump.  Better for the upgrade to keep the default value the same as the previous compiled in value.  From my reading there was no real meaning to the min_api value.  It was really just the default.  So this PR increases the default.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] shinrich commented on issue #6697: Increase the default max_record_entries to match the original value

Posted by GitBox <gi...@apache.org>.
shinrich commented on issue #6697:
URL: https://github.com/apache/trafficserver/pull/6697#issuecomment-617846240


   [approve ci autest]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] shinrich commented on issue #6697: Increase the default max_record_entries to match the original value

Posted by GitBox <gi...@apache.org>.
shinrich commented on issue #6697:
URL: https://github.com/apache/trafficserver/pull/6697#issuecomment-617872571


   [approve ci autest]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] zwoop commented on issue #6697: Increase the default max_record_entries to match the original value

Posted by GitBox <gi...@apache.org>.
zwoop commented on issue #6697:
URL: https://github.com/apache/trafficserver/pull/6697#issuecomment-618014036


   Fwiw, I retuned this such that it should have been the same number of metrics available to plugins (because, we deleted a lot of "core" metrics, freeing up the discrepancy. But, I'm fine with this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] zwoop commented on issue #6697: Increase the default max_record_entries to match the original value

Posted by GitBox <gi...@apache.org>.
zwoop commented on issue #6697:
URL: https://github.com/apache/trafficserver/pull/6697#issuecomment-618016137


   This closes #6472


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] shinrich commented on issue #6697: Increase the default max_record_entries to match the original value

Posted by GitBox <gi...@apache.org>.
shinrich commented on issue #6697:
URL: https://github.com/apache/trafficserver/pull/6697#issuecomment-617916829


   [approve ci autest]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org