You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucy.apache.org by "Peter Karman (JIRA)" <ji...@apache.org> on 2009/12/12 03:32:18 UTC
[jira] Created: (LUCY-88) change Charmonizer to use the standard
stdint.h integer types
change Charmonizer to use the standard stdint.h integer types
-------------------------------------------------------------
Key: LUCY-88
URL: https://issues.apache.org/jira/browse/LUCY-88
Project: Lucy
Issue Type: Improvement
Components: Charmonizer
Reporter: Peter Karman
Charmonizer currently uses non-standard type names for specific integer sizes. It would be more portable and easier for first-timers to grok if we used the standard stdint.h types instead, generating a usable stdint.h on systems where it isn't available.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (LUCY-88) change Charmonizer to use the standard
stdint.h integer types
Posted by "Marvin Humphrey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCY-88?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marvin Humphrey updated LUCY-88:
--------------------------------
Attachment: stdint_h.patch
Looks great!
I've uploaded a version of the patch which adds some documentation
to Charmonizer/Probe/Integers.h and changes over the existing tests
for e.g. u8_t to apply to uint8_t.
> change Charmonizer to use the standard stdint.h integer types
> -------------------------------------------------------------
>
> Key: LUCY-88
> URL: https://issues.apache.org/jira/browse/LUCY-88
> Project: Lucy
> Issue Type: Improvement
> Components: Charmonizer
> Reporter: Peter Karman
> Attachments: stdint_h.patch, stdint_h.patch
>
>
> Charmonizer currently uses non-standard type names for specific integer sizes. It would be more portable and easier for first-timers to grok if we used the standard stdint.h types instead, generating a usable stdint.h on systems where it isn't available.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (LUCY-88) change Charmonizer to use the standard
stdint.h integer types
Posted by "Peter Karman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCY-88?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Karman updated LUCY-88:
-----------------------------
Attachment: stdint_h.patch
this patch against r889879 adds stdint.h support
> change Charmonizer to use the standard stdint.h integer types
> -------------------------------------------------------------
>
> Key: LUCY-88
> URL: https://issues.apache.org/jira/browse/LUCY-88
> Project: Lucy
> Issue Type: Improvement
> Components: Charmonizer
> Reporter: Peter Karman
> Attachments: stdint_h.patch
>
>
> Charmonizer currently uses non-standard type names for specific integer sizes. It would be more portable and easier for first-timers to grok if we used the standard stdint.h types instead, generating a usable stdint.h on systems where it isn't available.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (LUCY-88) change Charmonizer to use the standard
stdint.h integer types
Posted by "Marvin Humphrey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCY-88?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marvin Humphrey resolved LUCY-88.
---------------------------------
Resolution: Fixed
Assignee: Marvin Humphrey
Committed as r890006.
After making an additional change to Clownfish as r890005 to add typemaps
for the stdint.h types to the Perl bindings, I was able to perform a
s/i64_t/int64_t/g for InStream.h/InStream.c and have all tests pass.
> change Charmonizer to use the standard stdint.h integer types
> -------------------------------------------------------------
>
> Key: LUCY-88
> URL: https://issues.apache.org/jira/browse/LUCY-88
> Project: Lucy
> Issue Type: Improvement
> Components: Charmonizer
> Reporter: Peter Karman
> Assignee: Marvin Humphrey
> Attachments: stdint_h.patch, stdint_h.patch
>
>
> Charmonizer currently uses non-standard type names for specific integer sizes. It would be more portable and easier for first-timers to grok if we used the standard stdint.h types instead, generating a usable stdint.h on systems where it isn't available.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.