You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/02 15:07:36 UTC
[GitHub] [arrow] lwhite1 opened a new pull request, #14573: Merge and extend MutableTable code
lwhite1 opened a new pull request, #14573:
URL: https://github.com/apache/arrow/pull/14573
Initial merge of MutableTable / MutableRow plus tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14573: ARROW-18237: [Java] Extend Table code
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14573:
URL: https://github.com/apache/arrow/pull/14573#issuecomment-1330760811
https://issues.apache.org/jira/browse/ARROW-18237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lwhite1 commented on pull request #14573: ARROW-18237: [Java] Merge and extend MutableTable code
Posted by GitBox <gi...@apache.org>.
lwhite1 commented on PR #14573:
URL: https://github.com/apache/arrow/pull/14573#issuecomment-1307560711
@davisusanibar Would you please review. This is a partial implementation but it's already quite large. The code is mostly very simple and well tested. I think before adding anything more it would be best to review and merge what's here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14573: Merge and extend MutableTable code
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14573:
URL: https://github.com/apache/arrow/pull/14573#issuecomment-1300871923
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lwhite1 commented on a diff in pull request #14573: ARROW-18237: [Java] Extend Table code
Posted by GitBox <gi...@apache.org>.
lwhite1 commented on code in PR #14573:
URL: https://github.com/apache/arrow/pull/14573#discussion_r1035193626
##########
java/vector/src/main/java/org/apache/arrow/vector/table/Row.java:
##########
@@ -98,6 +102,8 @@
import org.apache.arrow.vector.holders.NullableUInt8Holder;
/**
+ * TODO: Modify the getters for Duration and others so that they return something better than ArrowBuf when possible
Review Comment:
removed obsolete TODOs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #14573: ARROW-18237: [Java] Extend Table code
Posted by GitBox <gi...@apache.org>.
lidavidm commented on code in PR #14573:
URL: https://github.com/apache/arrow/pull/14573#discussion_r1035159663
##########
java/vector/src/main/java/org/apache/arrow/vector/table/Row.java:
##########
@@ -98,6 +102,8 @@
import org.apache.arrow.vector.holders.NullableUInt8Holder;
/**
+ * TODO: Modify the getters for Duration and others so that they return something better than ArrowBuf when possible
Review Comment:
Did you mean to leave this TODO in here? (It should perhaps be linked to an issue?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lwhite1 commented on pull request #14573: ARROW-18237: [Java] Extend Table code
Posted by GitBox <gi...@apache.org>.
lwhite1 commented on PR #14573:
URL: https://github.com/apache/arrow/pull/14573#issuecomment-1331079900
@lidavidm Could you please give this a final check and merge? It was originally intended to include new code for mutable table support but has been simplified to include adding a small number of necessary methods to the existing classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm merged pull request #14573: ARROW-18237: [Java] Extend Table code
Posted by GitBox <gi...@apache.org>.
lidavidm merged PR #14573:
URL: https://github.com/apache/arrow/pull/14573
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14573: ARROW-18237: [Java] Extend Table code
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14573:
URL: https://github.com/apache/arrow/pull/14573#issuecomment-1330760894
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #14573: ARROW-18237: [Java] Extend Table code
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14573:
URL: https://github.com/apache/arrow/pull/14573#issuecomment-1332087030
Benchmark runs are scheduled for baseline = 3b0e1357d3454675efc2967e41a14943f41feeb0 and contender = 2e9611a8e678b2661001afc429e6baadba81a34e. 2e9611a8e678b2661001afc429e6baadba81a34e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:25.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/277bd9a92bed444ab42e86b3714123ef...834bb8eb44b649ca8ceb5af51cdb3a0a/)
[Failed :arrow_down:0.1% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/84eddf5bd5534859b32e68748b8d77ad...0fa468fe483f443486f3b572e224774a/)
[Finished :arrow_down:0.27% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/30a3b4aa2ae743a2a39fbd71c18ee67d...4a05187130564eb4a0dd49de0d32bd3a/)
[Finished :arrow_down:0.17% :arrow_up:0.03%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/0f1a48795dbc4b9cabd2acd96f931903...7033c052d4b448929995d7062dbf3df6/)
Buildkite builds:
[Finished] [`2e9611a8` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1949)
[Failed] [`2e9611a8` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1971)
[Finished] [`2e9611a8` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1941)
[Finished] [`2e9611a8` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1963)
[Finished] [`3b0e1357` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1948)
[Failed] [`3b0e1357` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1970)
[Finished] [`3b0e1357` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1940)
[Finished] [`3b0e1357` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1962)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org