[GitHub] [iceberg] jackye1995 commented on a diff in pull request #5508: AWS: Add S3 preload client configuration

[GitBox <gi...@apache.org>]

jackye1995 commented on code in PR #5508:
URL: https://github.com/apache/iceberg/pull/5508#discussion_r944036770


##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -389,6 +389,19 @@ public class AwsProperties implements Serializable {
    */
   @Deprecated public static final boolean CLIENT_ENABLE_ETAG_CHECK_DEFAULT = false;
 
+  /**
+   * This flag controls whether the S3 client will be initialized during the S3FileIO
+   * initialization, instead of normal lazy initialization upon use. This is needed for cases that
+   * the credentials to use might change and needs to be preloaded.
+   *
+   * <p>In {@link GlueCatalog#newTableOps}, we will set this flag to true if 1) this table exists

Review Comment:
   this paragraph is not needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org