You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by ma...@apache.org on 2018/08/22 07:04:07 UTC
[trafficserver] 01/03: Cleanup: Remove
QUICAckFrameCreator::_create_frame()
This is an automated email from the ASF dual-hosted git repository.
masaori pushed a commit to branch quic-latest
in repository https://gitbox.apache.org/repos/asf/trafficserver.git
commit 45a5cdc92d4733141eeaf258df46c1c362890bb0
Author: Masaori Koshiba <ma...@apache.org>
AuthorDate: Wed Aug 22 12:16:13 2018 +0900
Cleanup: Remove QUICAckFrameCreator::_create_frame()
---
iocore/net/quic/QUICAckFrameCreator.cc | 9 +--------
iocore/net/quic/QUICAckFrameCreator.h | 1 -
2 files changed, 1 insertion(+), 9 deletions(-)
diff --git a/iocore/net/quic/QUICAckFrameCreator.cc b/iocore/net/quic/QUICAckFrameCreator.cc
index 77be562..cdfda94 100644
--- a/iocore/net/quic/QUICAckFrameCreator.cc
+++ b/iocore/net/quic/QUICAckFrameCreator.cc
@@ -52,7 +52,7 @@ QUICAckFrameCreator::update(QUICEncryptionLevel level, QUICPacketNumber packet_n
}
QUICFrameUPtr
-QUICAckFrameCreator::_create_frame(QUICEncryptionLevel level)
+QUICAckFrameCreator::generate_frame(QUICEncryptionLevel level, uint64_t connection_credit, uint16_t maximum_frame_size)
{
QUICFrameUPtr ack_frame = QUICFrameFactory::create_null_frame();
@@ -136,13 +136,6 @@ QUICAckFrameCreator::will_generate_frame(QUICEncryptionLevel level)
return this->_should_send[index];
}
-QUICFrameUPtr
-QUICAckFrameCreator::generate_frame(QUICEncryptionLevel level, uint64_t connection_credit, uint16_t maximum_frame_size)
-{
- // FIXME fix size
- return this->_create_frame(level);
-}
-
uint64_t
QUICAckFrameCreator::_calculate_delay(QUICEncryptionLevel level)
{
diff --git a/iocore/net/quic/QUICAckFrameCreator.h b/iocore/net/quic/QUICAckFrameCreator.h
index 4b69fcb..63c18f6 100644
--- a/iocore/net/quic/QUICAckFrameCreator.h
+++ b/iocore/net/quic/QUICAckFrameCreator.h
@@ -79,7 +79,6 @@ private:
* Returns QUICAckFrame only if ACK frame is able to be sent.
* Caller must send the ACK frame to the peer if it was returned.
*/
- QUICFrameUPtr _create_frame(QUICEncryptionLevel level);
QUICFrameUPtr _create_ack_frame(QUICEncryptionLevel level);
uint64_t _calculate_delay(QUICEncryptionLevel level);
std::vector<QUICEncryptionLevel>