You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/26 17:19:34 UTC

[GitHub] [arrow] paddyhoran commented on pull request #8664: ARROW-10588: [Rust] Safe and parallel bit operations for Arrow

paddyhoran commented on pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#issuecomment-734413544


   Hi @vertexclique.  
   
   All your contributions are very much appreciated.  You are one of the most advanced contributors to the project meaning that it's important for the other members of the community to be able to review and ask questions.  This may be frustrating for you but it is necessary.
   
   In general, smaller more focused PR's will be easier to merge.  Larger PR's or ones that are low level in nature need to be reviewed in more depth and we should be glad to have @jhorstmann and others to provide constructive feedback.  *Also, you may be asked to make changes to your PR's and you may not always agree.  This can always happen in a community run project.* 
   
   In general, you need to not take feedback so personally.  I have re-read the interactions you mentioned and I'm sorry I can't see the issues you are referring to and I think you were wrong to call out @jhorstmann.  On this PR I agreed with @jhorstmann's perspective, as did @alamb.  I at least thought the question was a good one to ask.
   
   On the other PR's you linked to it's clear that @jhorstmann is doing his best to be polite while providing feedback, for example:
    - `Just an idea, ...`
    - `Nice performance improvement! I'm a bit surprised... ` 
   
   Hopefully, you can move past this and keep contributing to the project.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org