You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2015/05/12 22:44:00 UTC
svn commit: r1679090 -
/tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
Author: markt
Date: Tue May 12 20:44:00 2015
New Revision: 1679090
URL: http://svn.apache.org/r1679090
Log:
Start to think about how incoming frames will be processed.
Modified:
tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java?rev=1679090&r1=1679089&r2=1679090&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java Tue May 12 20:44:00 2015
@@ -33,6 +33,9 @@ import org.apache.tomcat.util.res.String
* on the basis that there will never be more than one thread performing I/O at
* a time.
* <br>
+ * For reading, this implementation is blocking within frames and non-blocking
+ * between frames.
+ * <br>
* Note that unless Tomcat is configured with an ECC certificate, FireFox
* (tested with v37.0.2) needs to be configured with
* network.http.spdy.enforce-tls-profile=false in order for FireFox to be able
@@ -86,11 +89,16 @@ public class Http2UpgradeHandler impleme
}
connectionPrefaceParser = null;
- // TODO process frames
- break;
+ while (processFrame()) {
+ }
+
+ // TODO: CLOSED (GO_AWAY + no open streams apart from 0?) vs LONG
+ return SocketState.CLOSED;
+
case OPEN_WRITE:
// TODO
break;
+
case ASYNC_READ_ERROR:
case ASYNC_WRITE_ERROR:
case CLOSE_NOW:
@@ -116,6 +124,11 @@ public class Http2UpgradeHandler impleme
}
+ private boolean processFrame() {
+ return false;
+ }
+
+
@Override
public void destroy() {
// NO-OP
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org