[GitHub] spark pull request #15505: [SPARK-18890][CORE] Move task serialization from ...

[squito <gi...@git.apache.org>]

Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15505#discussion_r95199529
  
    --- Diff: core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala ---
    @@ -592,47 +579,6 @@ class TaskSetManagerSuite extends SparkFunSuite with LocalSparkContext with Logg
         assert(manager.resourceOffer("execB", "host2", RACK_LOCAL).get.index === 1)
       }
     
    -  test("do not emit warning when serialized task is small") {
    --- End diff --
    
    This may be a stretch, but `Task` *could* be big, right?  Eg. if there was a long chain of partitions, and for some reason they had a lot of data?  That seems unlikely, but I also have no idea if it ever happens or not.  It seems easy enough to add the check back in -- is there any reason not to?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org