[GitHub] [beam] Dippatel98 commented on a diff in pull request #26970: Added dlq and error metrics to SpannerChangestreamsReadSchemaTransformProvider

["Dippatel98 (via GitHub)" <gi...@apache.org>]

Dippatel98 commented on code in PR #26970:
URL: https://github.com/apache/beam/pull/26970#discussion_r1218315758


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/SpannerChangestreamsReadSchemaTransformProvider.java:
##########
@@ -193,15 +218,19 @@ public abstract static class Builder {
     }
   }
 
-  private static final class DataChangeRecordToRow extends DoFn<DataChangeRecord, Row> {
+  public static final class DataChangeRecordToRow extends DoFn<DataChangeRecord, Row> {

Review Comment:
   In order to test it in the SpannerChangestreamsReadDlqTest. There didn't seem a straight forward way to test the dlq. So I tested the DoFn itself.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org