Clean up of the test code

[Willem Jiang <wi...@gmail.com>]

Hi,

I'm working on this JIRA[1] after a quick review of current tests code.

There are lots of improvements that we can working on such as
1. Leverage the log instead of System.out.println to log the message.
2. Throw out the exception out directly in the unit test.
3. Make sure the test code is doing it work to avoid the regression issue (
There are some tests are ignored to run in the CI)

I just commit a quick fix of the rocketmq-store module, there are still
some other issues need to fix, I create another JIRA[2] for it. I'm here to
call for help, please take some time to fix it.

[1]https://issues.apache.org/jira/browse/ROCKETMQ-3
[2]https://issues.apache.org/jira/browse/ROCKETMQ-9

Willem Jiang

Blog: http://willemjiang.blogspot.com (English)
          http://jnn.iteye.com  (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem

Re: Clean up of the test code

[Roman Shtykh <rs...@yahoo.com.INVALID>]

Hi Willem,
"Address already in use" issue of ROCKETMQ-9 is a duplicate of ROCKETMQ-2.
-Roman
 

    On Friday, December 23, 2016 1:38 PM, Willem Jiang <wi...@gmail.com> wrote:
 

 Hi,

I'm working on this JIRA[1] after a quick review of current tests code.

There are lots of improvements that we can working on such as
1. Leverage the log instead of System.out.println to log the message.
2. Throw out the exception out directly in the unit test.
3. Make sure the test code is doing it work to avoid the regression issue (
There are some tests are ignored to run in the CI)

I just commit a quick fix of the rocketmq-store module, there are still
some other issues need to fix, I create another JIRA[2] for it. I'm here to
call for help, please take some time to fix it.

[1]https://issues.apache.org/jira/browse/ROCKETMQ-3
[2]https://issues.apache.org/jira/browse/ROCKETMQ-9

Willem Jiang

Blog: http://willemjiang.blogspot.com (English)
          http://jnn.iteye.com  (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem