You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "SunnyChaturvedi (via GitHub)" <gi...@apache.org> on 2023/02/24 15:09:40 UTC
[GitHub] [kafka] SunnyChaturvedi opened a new pull request, #13298: MINOR: Fix flaky testIdleConnection() test (apache/kafka#11996 cherrypick)
SunnyChaturvedi opened a new pull request, #13298:
URL: https://github.com/apache/kafka/pull/13298
The fix is in the upstream trunk (apache/kafka#11996)
The test expects that the connection becomes idle before the mock time is moved forward, but the processor thread runs concurrently and may run some activity on the connection after the mock time is moved forward, thus the connection never expires.
The solution is to wait until the message is received on the socket, and only then wait until the connection is unmuted (it's not enough to wait for unmuted without waiting for message being received on the socket, because the channel might have not been muted yet).
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] SunnyChaturvedi closed pull request #13298: MINOR: Fix flaky testIdleConnection() test (apache/kafka#11996 cherrypick)
Posted by "SunnyChaturvedi (via GitHub)" <gi...@apache.org>.
SunnyChaturvedi closed pull request #13298: MINOR: Fix flaky testIdleConnection() test (apache/kafka#11996 cherrypick)
URL: https://github.com/apache/kafka/pull/13298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] SunnyChaturvedi closed pull request #13298: MINOR: Fix flaky testIdleConnection() test (apache/kafka#11996 cherrypick)
Posted by "SunnyChaturvedi (via GitHub)" <gi...@apache.org>.
SunnyChaturvedi closed pull request #13298: MINOR: Fix flaky testIdleConnection() test (apache/kafka#11996 cherrypick)
URL: https://github.com/apache/kafka/pull/13298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] SunnyChaturvedi commented on pull request #13298: MINOR: Fix flaky testIdleConnection() test (apache/kafka#11996 cherrypick)
Posted by "SunnyChaturvedi (via GitHub)" <gi...@apache.org>.
SunnyChaturvedi commented on PR #13298:
URL: https://github.com/apache/kafka/pull/13298#issuecomment-1443839598
opened to trunk by mistake, closing it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org