[GitHub] [arrow-datafusion] mingmwang commented on a diff in pull request #6657: RowAccumulators support generics

["mingmwang (via GitHub)" <gi...@apache.org>]

mingmwang commented on code in PR #6657:
URL: https://github.com/apache/arrow-datafusion/pull/6657#discussion_r1228954668


##########
datafusion/row/src/reader.rs:
##########
@@ -142,7 +140,8 @@ impl<'a> RowReader<'a> {
         self.data = data;
     }
 
-    #[inline]
+    #[allow(dead_code)]
+    #[inline(always)]
     fn assert_index_valid(&self, idx: usize) {

Review Comment:
   This is not used in current code. I leave it here, this check can be invoked for each record batch.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org