You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Randy Kobes <ra...@theoryx5.uwinnipeg.ca> on 2004/06/26 22:25:35 UTC
Re: Using mp2's APR::PerlIO and apr_perlio.h
On Sat, 26 Jun 2004, Joe Schaefer wrote:
> Randy Kobes <ra...@theoryx5.uwinnipeg.ca> writes:
>
> > On Sat, 26 Jun 2004, Joe Schaefer wrote:
>
> [...]
>
> > > Is there a better way, or should I just go
> > > ahead and add the header file?
> >
> > I think it's relatively straightforward to add apr_perlio.h
> > to the list of header files mp2 installs into the
> > Apache2/include/ directory (eg, in mp2's top-level
> > Makefile.PL, add apr_perlio.h to the @xs_h_files array).
>
> That'll certainly work, however I don't want to hold up
> progress on apreq-dev while mp2 sorts this out. Instead
> of adding the file, I'll just append the necessary declaration
> to apreq_xs_postperl.h.
Sounds good ... For future consideration, here's a diff
against the top-level mp2 Makefile.PL which will add
apr_perlio.h to the list of xs header files that get
installed under the Apache2 include/ directory.
=========================================================
Index: Makefile.PL
===================================================================
RCS file: /home/cvs/modperl-2.0/Makefile.PL,v
retrieving revision 1.139
diff -u -r1.139 Makefile.PL
--- Makefile.PL 26 Jun 2004 19:41:53 -0000 1.139
+++ Makefile.PL 26 Jun 2004 20:18:19 -0000
@@ -57,7 +57,8 @@
# these h files need to be installed system-wide so 3rd party XS
# extensions can use them
my @xs_h_files = map catfile("xs", $_),
- qw(modperl_xs_sv_convert.h modperl_xs_typedefs.h modperl_xs_util.h);
+ qw(modperl_xs_sv_convert.h modperl_xs_typedefs.h modperl_xs_util.h
+ APR/PerlIO/apr_perlio.h);
my @exe_files = map "bin/$_", qw(mp2doc mp2bug);
==================================================================
--
best regards,
randy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: Using mp2's APR::PerlIO and apr_perlio.h
Posted by Stas Bekman <st...@stason.org>.
Randy Kobes wrote:
> On Sat, 26 Jun 2004, Joe Schaefer wrote:
>
>
>>Randy Kobes <ra...@theoryx5.uwinnipeg.ca> writes:
>>
>>
>>>On Sat, 26 Jun 2004, Joe Schaefer wrote:
>>
>>[...]
>>
>>
>>>>Is there a better way, or should I just go
>>>>ahead and add the header file?
>>>
>>>I think it's relatively straightforward to add apr_perlio.h
>>>to the list of header files mp2 installs into the
>>>Apache2/include/ directory (eg, in mp2's top-level
>>>Makefile.PL, add apr_perlio.h to the @xs_h_files array).
>>
>>That'll certainly work, however I don't want to hold up
>>progress on apreq-dev while mp2 sorts this out. Instead
>>of adding the file, I'll just append the necessary declaration
>>to apreq_xs_postperl.h.
>
>
> Sounds good ... For future consideration, here's a diff
> against the top-level mp2 Makefile.PL which will add
> apr_perlio.h to the list of xs header files that get
> installed under the Apache2 include/ directory.
> =========================================================
> Index: Makefile.PL
> ===================================================================
> RCS file: /home/cvs/modperl-2.0/Makefile.PL,v
> retrieving revision 1.139
> diff -u -r1.139 Makefile.PL
> --- Makefile.PL 26 Jun 2004 19:41:53 -0000 1.139
> +++ Makefile.PL 26 Jun 2004 20:18:19 -0000
> @@ -57,7 +57,8 @@
> # these h files need to be installed system-wide so 3rd party XS
> # extensions can use them
> my @xs_h_files = map catfile("xs", $_),
> - qw(modperl_xs_sv_convert.h modperl_xs_typedefs.h modperl_xs_util.h);
> + qw(modperl_xs_sv_convert.h modperl_xs_typedefs.h modperl_xs_util.h
> + APR/PerlIO/apr_perlio.h);
>
> my @exe_files = map "bin/$_", qw(mp2doc mp2bug);
+1
but first I think it's a good idea to
s/apr_perlio\.([ch])/modperl_apr_perlio.$1/ and adjust the includes
appropriately. I guess when I wrote that I didn't think it's going to be used
by other projects, hence the short chosen name.
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: Using mp2's APR::PerlIO and apr_perlio.h
Posted by Stas Bekman <st...@stason.org>.
Randy Kobes wrote:
> On Sat, 26 Jun 2004, Joe Schaefer wrote:
>
>
>>Randy Kobes <ra...@theoryx5.uwinnipeg.ca> writes:
>>
>>
>>>On Sat, 26 Jun 2004, Joe Schaefer wrote:
>>
>>[...]
>>
>>
>>>>Is there a better way, or should I just go
>>>>ahead and add the header file?
>>>
>>>I think it's relatively straightforward to add apr_perlio.h
>>>to the list of header files mp2 installs into the
>>>Apache2/include/ directory (eg, in mp2's top-level
>>>Makefile.PL, add apr_perlio.h to the @xs_h_files array).
>>
>>That'll certainly work, however I don't want to hold up
>>progress on apreq-dev while mp2 sorts this out. Instead
>>of adding the file, I'll just append the necessary declaration
>>to apreq_xs_postperl.h.
>
>
> Sounds good ... For future consideration, here's a diff
> against the top-level mp2 Makefile.PL which will add
> apr_perlio.h to the list of xs header files that get
> installed under the Apache2 include/ directory.
> =========================================================
> Index: Makefile.PL
> ===================================================================
> RCS file: /home/cvs/modperl-2.0/Makefile.PL,v
> retrieving revision 1.139
> diff -u -r1.139 Makefile.PL
> --- Makefile.PL 26 Jun 2004 19:41:53 -0000 1.139
> +++ Makefile.PL 26 Jun 2004 20:18:19 -0000
> @@ -57,7 +57,8 @@
> # these h files need to be installed system-wide so 3rd party XS
> # extensions can use them
> my @xs_h_files = map catfile("xs", $_),
> - qw(modperl_xs_sv_convert.h modperl_xs_typedefs.h modperl_xs_util.h);
> + qw(modperl_xs_sv_convert.h modperl_xs_typedefs.h modperl_xs_util.h
> + APR/PerlIO/apr_perlio.h);
>
> my @exe_files = map "bin/$_", qw(mp2doc mp2bug);
+1
but first I think it's a good idea to
s/apr_perlio\.([ch])/modperl_apr_perlio.$1/ and adjust the includes
appropriately. I guess when I wrote that I didn't think it's going to be used
by other projects, hence the short chosen name.
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com