You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2020/11/18 03:20:39 UTC

[GitHub] [avro] blachniet commented on a change in pull request #990: Bump Newtonsoft.Json from 10.0.3 to 12.0.3 in /lang/csharp

blachniet commented on a change in pull request #990:
URL: https://github.com/apache/avro/pull/990#discussion_r525723380



##########
File path: lang/csharp/src/apache/main/Avro.main.csproj
##########
@@ -56,7 +56,7 @@
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
-    <PackageReference Include="Newtonsoft.Json" Version="10.0.3" />
+    <PackageReference Include="Newtonsoft.Json" Version="12.0.3" />

Review comment:
       Hey @iemejia,
   
   We actually don't want to update this dependency in this library. There's an extended description of the problem [here](https://github.com/apache/avro/pull/981#discussion_r525692847).
   
   The [docs here](https://dependabot.com/docs/config-file/) show how I can configure `ignored_updates` in the `dependabot.yml`. Is there a way I can test out locally that the configuration change is working?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org