[jira] [Updated] (OAK-627) Move CommitHook(s) from KernelNodeStore to RootImpl

["Jukka Zitting (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OAK-627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting updated OAK-627:
------------------------------

    Attachment: 0001-OAK-627-Move-CommitHook-s-from-KernelNodeStore-to-Ro.patch

Attached my take on this.

I'd solve the OakInitializer issue by making it explicitly in charge of the commit hooks being used. It's run *before* the repository is fully set up and within the context of the Oak class (or a similar setup routine) where we already know which hooks should be available.

Another tricky bit here is the complex sequence of login machinery that now all need to track the hook instance in addition to the node store and index provider they already pass around. I think we need to look closer at how that setup should be simplified.
                
> Move CommitHook(s) from KernelNodeStore to RootImpl
> ---------------------------------------------------
>
>                 Key: OAK-627
>                 URL: https://issues.apache.org/jira/browse/OAK-627
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: angela
>         Attachments: 0001-OAK-627-Move-CommitHook-s-from-KernelNodeStore-to-Ro.patch
>
>
> see http://markmail.org/message/wfacqc4ojpgi3yjv for the corresponding
> discussion on the dev list.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira