[GitHub] [cassandra] smiklosovic commented on a diff in pull request #2276: CASSANDRA-18336

["smiklosovic (via GitHub)" <gi...@apache.org>]

smiklosovic commented on code in PR #2276:
URL: https://github.com/apache/cassandra/pull/2276#discussion_r1168530866


##########
test/unit/org/apache/cassandra/service/DiskFailurePolicyTest.java:
##########
@@ -124,12 +135,29 @@ public void teardown()
     public void testPolicies()
     {
         DatabaseDescriptor.setDiskFailurePolicy(testPolicy);
-        JVMStabilityInspector.inspectThrowable(t);
-        Assert.assertEquals(expectJVMKilled, killerForTests.wasKilled());
-        Assert.assertEquals(expectJVMKilledQuiet, killerForTests.wasKilledQuietly());
-        if (!expectJVMKilled) {
+        try
+        {
+            JVMStabilityInspector.inspectThrowable(t);
+        }
+        catch (OutOfMemoryError e)

Review Comment:
   this is eventually thrown by `JVMStabilityInspector.inspectThrowable(t);` if you follow it deeply. We just need to make the difference between oom thrown as part of the test and oom thrown _while running a test_.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org