[jira] Commented: (JAMES-513) Rename AddHeader and AddHeaderHandler

["Norman Maurer (JIRA)" <se...@james.apache.org>]

    [ http://issues.apache.org/jira/browse/JAMES-513?page=comments#action_12413783 ] 

Norman Maurer commented on JAMES-513:
-------------------------------------

when working on junit test for AddHeaderHandler i notice that the
AddHeaderHandler use setHeader(String name, String value); . So it not
add a header, it set a header. This is not what i espected when i read
the Handlername.

So for me are 2 solutions:

1. Rename the AddHeaderHandler to SetHeaderHandler
2. use addHeader(String name, String value) instand of setHeader(String
name, String value)

i prefer the first. What the you think ?

> Rename AddHeader and AddHeaderHandler
> -------------------------------------
>
>          Key: JAMES-513
>          URL: http://issues.apache.org/jira/browse/JAMES-513
>      Project: James
>         Type: Task

>     Reporter: Norman Maurer

>
> We should rename AddHeader and AddHeaderHandler to represent the function.
>  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org