You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "C. Michael Pilato" <cm...@collab.net> on 2011/07/20 17:51:18 UTC
Does the fix for "case-only renames" merit a Release Note?
It seems to me that the fixes Johan made for case-only renames (obviously
empowered by WC-NG) could be the sort of high-profile bugfix that merit a
mention in the release notes. I certainly don't want to start a torrent of
discussion about which bugfixes "make the cut" -- but maybe there are a
handful of similarly weighted bugfixes that we could call out? Thoughts?
--
C. Michael Pilato <cm...@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand
Re: Does the fix for "case-only renames" merit a Release Note?
Posted by Julian Foad <ju...@wandisco.com>.
On Wed, 2011-07-20 at 11:51 -0400, C. Michael Pilato wrote:
> It seems to me that the fixes Johan made for case-only renames (obviously
> empowered by WC-NG) could be the sort of high-profile bugfix that merit a
> mention in the release notes. I certainly don't want to start a torrent of
> discussion about which bugfixes "make the cut" -- but maybe there are a
> handful of similarly weighted bugfixes that we could call out? Thoughts?
Probably this does warrant a mention, yes. It's good to call out a few
specific improvements that some groups of users will be very glad to
see.
What exactly is now supported in terms of case-only renames? Can anyone
point to a description of it?
- Julian
Re: Does the fix for "case-only renames" merit a Release Note?
Posted by Johan Corveleyn <jc...@gmail.com>.
On Thu, Sep 15, 2011 at 11:30 PM, Daniel Shahaf <d....@daniel.shahaf.name> wrote:
> Johan Corveleyn wrote on Thu, Sep 15, 2011 at 22:54:24 +0200:
>> On Thu, Jul 21, 2011 at 2:03 PM, Johan Corveleyn <jc...@gmail.com> wrote:
>> > On Wed, Jul 20, 2011 at 7:47 PM, Ivan Zhakov <iv...@visualsvn.com> wrote:
>> >> On Wed, Jul 20, 2011 at 19:51, C. Michael Pilato <cm...@collab.net> wrote:
>> >>> It seems to me that the fixes Johan made for case-only renames (obviously
>> >>> empowered by WC-NG) could be the sort of high-profile bugfix that merit a
>> >>> mention in the release notes.
>> >> +1, this is really important fix for Windows users.
>> >
>> > +1
>> >
>> > I'm on holiday right now, so only following from a distance...
>> >
>> > To give a quick idea of what's changed concretely: it's really only
>> > about "svn mv A a", which would yield "svn: Cannot move path 'A' into
>> > itself" in 1.6, and now just does the right thing. It works for both
>> > files and directories. This is issue 3702 [1].
>> >
>> > Additionally, issue 3865 [2] was fixed to make this more useful,
>> > because otherwise all other subcommands could not "reach" the deleted
>> > part of the move, because case-normalization took over (hence this was
>> > needed to be able to commit the move in full).
>> >
>> > I don't have time to contribute for the release notes or anything, so
>> > if someone else can pick this up ... that would be nice.
>> >
>> > --
>> > Johan
>> >
>> > [1] http://subversion.tigris.org/issues/show_bug.cgi?id=3702 (Unable
>> > to perform case-only rename on windows)
>> > [2] http://subversion.tigris.org/issues/show_bug.cgi?id=3865 ('svn' on
>> > Windows cannot address scheduled-for-delete file, if another file
>> > differing only in case is present on disk)
>>
>> I almost forgot about this (holidays tend to do that, don't they :-)).
>>
>> Is there still time to add something about this to the release notes?
>
> Yes, plenty. 1.8.0 hasn't been released yet.
>
>> Any objections?
>>
>> I could write something like: "Subversion on Windows now fully
>> supports changing the case of file and directory names. No more
>> special workarounds, a simple 'svn mv file.java File.java' just does
>> the right thing."
>>
>> Maybe with a link to the relevant FAQ entry [1]. But maybe that FAQ
>> entry should be removed post-1.7, or at least mention that it's only
>> needed for <1.7 (except the part about the check-case-insensitive.py
>> pre-commit hook to avoid case-conflicts from being committed, which
>> will still be valid/useful).
>>
>> But where do I put this? The only section in the release notes that
>> seems appropriate is "Bug fixes (client and server)", which now only
>> mentions that many bugs have been fixed, and directs people to the
>> CHANGES file. But if this is the only bugfix that will be called out
>> explicitly, I think it would be a little bit odd.
>>
>
> You could add it as a sibling to the #libmagic-support section?
>
> Anyway, just add it, if it doesn't look right we can move it later.
Phew, for some reason it took me a huge amount of time, but I finally
got it committed :-).
r1175256
--
Johan
Re: Does the fix for "case-only renames" merit a Release Note?
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Johan Corveleyn wrote on Thu, Sep 15, 2011 at 22:54:24 +0200:
> On Thu, Jul 21, 2011 at 2:03 PM, Johan Corveleyn <jc...@gmail.com> wrote:
> > On Wed, Jul 20, 2011 at 7:47 PM, Ivan Zhakov <iv...@visualsvn.com> wrote:
> >> On Wed, Jul 20, 2011 at 19:51, C. Michael Pilato <cm...@collab.net> wrote:
> >>> It seems to me that the fixes Johan made for case-only renames (obviously
> >>> empowered by WC-NG) could be the sort of high-profile bugfix that merit a
> >>> mention in the release notes.
> >> +1, this is really important fix for Windows users.
> >
> > +1
> >
> > I'm on holiday right now, so only following from a distance...
> >
> > To give a quick idea of what's changed concretely: it's really only
> > about "svn mv A a", which would yield "svn: Cannot move path 'A' into
> > itself" in 1.6, and now just does the right thing. It works for both
> > files and directories. This is issue 3702 [1].
> >
> > Additionally, issue 3865 [2] was fixed to make this more useful,
> > because otherwise all other subcommands could not "reach" the deleted
> > part of the move, because case-normalization took over (hence this was
> > needed to be able to commit the move in full).
> >
> > I don't have time to contribute for the release notes or anything, so
> > if someone else can pick this up ... that would be nice.
> >
> > --
> > Johan
> >
> > [1] http://subversion.tigris.org/issues/show_bug.cgi?id=3702 (Unable
> > to perform case-only rename on windows)
> > [2] http://subversion.tigris.org/issues/show_bug.cgi?id=3865 ('svn' on
> > Windows cannot address scheduled-for-delete file, if another file
> > differing only in case is present on disk)
>
> I almost forgot about this (holidays tend to do that, don't they :-)).
>
> Is there still time to add something about this to the release notes?
Yes, plenty. 1.8.0 hasn't been released yet.
> Any objections?
>
> I could write something like: "Subversion on Windows now fully
> supports changing the case of file and directory names. No more
> special workarounds, a simple 'svn mv file.java File.java' just does
> the right thing."
>
> Maybe with a link to the relevant FAQ entry [1]. But maybe that FAQ
> entry should be removed post-1.7, or at least mention that it's only
> needed for <1.7 (except the part about the check-case-insensitive.py
> pre-commit hook to avoid case-conflicts from being committed, which
> will still be valid/useful).
>
> But where do I put this? The only section in the release notes that
> seems appropriate is "Bug fixes (client and server)", which now only
> mentions that many bugs have been fixed, and directs people to the
> CHANGES file. But if this is the only bugfix that will be called out
> explicitly, I think it would be a little bit odd.
>
You could add it as a sibling to the #libmagic-support section?
Anyway, just add it, if it doesn't look right we can move it later.
> Maybe other more-or-less-high-profile bugfixes can also be mentioned?
>
> If it's too late for all of this, no problem.
>
>
> [1] http://subversion.apache.org/faq.html#case-change
>
> --
> Johan
Re: Does the fix for "case-only renames" merit a Release Note?
Posted by Johan Corveleyn <jc...@gmail.com>.
On Thu, Jul 21, 2011 at 2:03 PM, Johan Corveleyn <jc...@gmail.com> wrote:
> On Wed, Jul 20, 2011 at 7:47 PM, Ivan Zhakov <iv...@visualsvn.com> wrote:
>> On Wed, Jul 20, 2011 at 19:51, C. Michael Pilato <cm...@collab.net> wrote:
>>> It seems to me that the fixes Johan made for case-only renames (obviously
>>> empowered by WC-NG) could be the sort of high-profile bugfix that merit a
>>> mention in the release notes.
>> +1, this is really important fix for Windows users.
>
> +1
>
> I'm on holiday right now, so only following from a distance...
>
> To give a quick idea of what's changed concretely: it's really only
> about "svn mv A a", which would yield "svn: Cannot move path 'A' into
> itself" in 1.6, and now just does the right thing. It works for both
> files and directories. This is issue 3702 [1].
>
> Additionally, issue 3865 [2] was fixed to make this more useful,
> because otherwise all other subcommands could not "reach" the deleted
> part of the move, because case-normalization took over (hence this was
> needed to be able to commit the move in full).
>
> I don't have time to contribute for the release notes or anything, so
> if someone else can pick this up ... that would be nice.
>
> --
> Johan
>
> [1] http://subversion.tigris.org/issues/show_bug.cgi?id=3702 (Unable
> to perform case-only rename on windows)
> [2] http://subversion.tigris.org/issues/show_bug.cgi?id=3865 ('svn' on
> Windows cannot address scheduled-for-delete file, if another file
> differing only in case is present on disk)
I almost forgot about this (holidays tend to do that, don't they :-)).
Is there still time to add something about this to the release notes?
Any objections?
I could write something like: "Subversion on Windows now fully
supports changing the case of file and directory names. No more
special workarounds, a simple 'svn mv file.java File.java' just does
the right thing."
Maybe with a link to the relevant FAQ entry [1]. But maybe that FAQ
entry should be removed post-1.7, or at least mention that it's only
needed for <1.7 (except the part about the check-case-insensitive.py
pre-commit hook to avoid case-conflicts from being committed, which
will still be valid/useful).
But where do I put this? The only section in the release notes that
seems appropriate is "Bug fixes (client and server)", which now only
mentions that many bugs have been fixed, and directs people to the
CHANGES file. But if this is the only bugfix that will be called out
explicitly, I think it would be a little bit odd.
Maybe other more-or-less-high-profile bugfixes can also be mentioned?
If it's too late for all of this, no problem.
[1] http://subversion.apache.org/faq.html#case-change
--
Johan
Re: Does the fix for "case-only renames" merit a Release Note?
Posted by Johan Corveleyn <jc...@gmail.com>.
On Wed, Jul 20, 2011 at 7:47 PM, Ivan Zhakov <iv...@visualsvn.com> wrote:
> On Wed, Jul 20, 2011 at 19:51, C. Michael Pilato <cm...@collab.net> wrote:
>> It seems to me that the fixes Johan made for case-only renames (obviously
>> empowered by WC-NG) could be the sort of high-profile bugfix that merit a
>> mention in the release notes.
> +1, this is really important fix for Windows users.
+1
I'm on holiday right now, so only following from a distance...
To give a quick idea of what's changed concretely: it's really only
about "svn mv A a", which would yield "svn: Cannot move path 'A' into
itself" in 1.6, and now just does the right thing. It works for both
files and directories. This is issue 3702 [1].
Additionally, issue 3865 [2] was fixed to make this more useful,
because otherwise all other subcommands could not "reach" the deleted
part of the move, because case-normalization took over (hence this was
needed to be able to commit the move in full).
I don't have time to contribute for the release notes or anything, so
if someone else can pick this up ... that would be nice.
--
Johan
[1] http://subversion.tigris.org/issues/show_bug.cgi?id=3702 (Unable
to perform case-only rename on windows)
[2] http://subversion.tigris.org/issues/show_bug.cgi?id=3865 ('svn' on
Windows cannot address scheduled-for-delete file, if another file
differing only in case is present on disk)
Re: Does the fix for "case-only renames" merit a Release Note?
Posted by Ivan Zhakov <iv...@visualsvn.com>.
On Wed, Jul 20, 2011 at 19:51, C. Michael Pilato <cm...@collab.net> wrote:
> It seems to me that the fixes Johan made for case-only renames (obviously
> empowered by WC-NG) could be the sort of high-profile bugfix that merit a
> mention in the release notes.
+1, this is really important fix for Windows users.
--
Ivan Zhakov