You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by richard zhou <ri...@intel.com> on 2015/03/06 03:28:41 UTC

Review Request 31787: Sqoop-2183: Change resource type, privilege action and principal type from String to Enum.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31787/
-----------------------------------------------------------

Review request for Sqoop.


Repository: sqoop-sqoop2


Description
-------

Change resource type, privilege action and principal type from String to Enum.


Diffs
-----

  common/src/main/java/org/apache/sqoop/model/MPrincipal.java 471d63edc21231500608ca12fefa85a96033d305 
  common/src/main/java/org/apache/sqoop/model/MPrivilege.java 25f719536b050a65fd3cf6827a648268b3fba3ba 
  common/src/main/java/org/apache/sqoop/model/MResource.java b21ce1933a6206dd39f59d8623674494fe69e793 
  security/src/main/java/org/apache/sqoop/security/Authorization/AuthorizationEngine.java 09a9f3828e2804c837e56eb6f9fc7229073eb5bf 
  server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 41a8b95d74ff1cd3efcb00c6af593e3f9ffba2bf 
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 6dae043f4507faf386b0d6a87b70c3e7b32ad976 
  server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 0bffc63ae81eda36345524ef9732372642bc54f6 

Diff: https://reviews.apache.org/r/31787/diff/


Testing
-------

manual test


Thanks,

richard zhou


Re: Review Request 31787: Sqoop-2183: Change resource type, privilege action and principal type from String to Enum.

Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31787/#review75671
-----------------------------------------------------------

Ship it!


Ship It!

- Abraham Elmahrek


On March 6, 2015, 2:28 a.m., richard zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31787/
> -----------------------------------------------------------
> 
> (Updated March 6, 2015, 2:28 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Change resource type, privilege action and principal type from String to Enum.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/sqoop/model/MPrincipal.java 471d63edc21231500608ca12fefa85a96033d305 
>   common/src/main/java/org/apache/sqoop/model/MPrivilege.java 25f719536b050a65fd3cf6827a648268b3fba3ba 
>   common/src/main/java/org/apache/sqoop/model/MResource.java b21ce1933a6206dd39f59d8623674494fe69e793 
>   security/src/main/java/org/apache/sqoop/security/Authorization/AuthorizationEngine.java 09a9f3828e2804c837e56eb6f9fc7229073eb5bf 
>   server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 41a8b95d74ff1cd3efcb00c6af593e3f9ffba2bf 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 6dae043f4507faf386b0d6a87b70c3e7b32ad976 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 0bffc63ae81eda36345524ef9732372642bc54f6 
> 
> Diff: https://reviews.apache.org/r/31787/diff/
> 
> 
> Testing
> -------
> 
> manual test
> 
> 
> Thanks,
> 
> richard zhou
> 
>