You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samoa.apache.org by gdfm <gi...@git.apache.org> on 2015/10/26 14:14:11 UTC
[GitHub] incubator-samoa pull request: SAMOA-48: Multiple copies of evaluat...
GitHub user gdfm opened a pull request:
https://github.com/apache/incubator-samoa/pull/39
SAMOA-48: Multiple copies of evaluation statistics printed in ensemble methods
This fixes the multiple copies of the output.
Works fine for VHT.
For ensembles I ran into something that seems like a race condition.
Sometimes I get n votes (where n is the ensemble size) for the final instance multiple times, sometimes it doesn't even get to n votes (so it does not print).
This behavior is very weird because we are not using threads in local at all.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gdfm/incubator-samoa SAMOA-48
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-samoa/pull/39.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #39
----
commit af25e7d1f464323dcd0e2bb5729dc70e5ad36887
Author: Gianmarco De Francisci Morales <gd...@apache.org>
Date: 2015-10-26T12:20:55Z
SAMOA-48: Fix for VHT
commit 23169b0605005bf9b0b5f2dacb36a16b6b5b3b5d
Author: Gianmarco De Francisci Morales <gd...@apache.org>
Date: 2015-10-26T13:07:16Z
SAMOA-48: Fix for ensembles (race condition?)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-samoa pull request: SAMOA-48: Multiple copies of evaluat...
Posted by abifet <gi...@git.apache.org>.
Github user abifet commented on the pull request:
https://github.com/apache/incubator-samoa/pull/39#issuecomment-155085828
+1 I checked it using the covertype dataset, and data generated with the RandomTreeGenerator generator, and with the classifiers vht and bagging of vht.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-samoa pull request: SAMOA-48: Multiple copies of evaluat...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-samoa/pull/39
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---