[trafficserver] branch master updated: Make sure new metrics are always considered (#10445)

[zw...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

zwoop pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/master by this push:
     new 88f459c719 Make sure new metrics are always considered (#10445)
88f459c719 is described below

commit 88f459c719ee361178f44266c7c7e06777ef1107
Author: Leif Hedstrom <zw...@apache.org>
AuthorDate: Thu Sep 21 10:44:37 2023 -0600

    Make sure new metrics are always considered (#10445)
---
 src/records/RecCore.cc | 41 ++++++++++++++++++++---------------------
 1 file changed, 20 insertions(+), 21 deletions(-)

diff --git a/src/records/RecCore.cc b/src/records/RecCore.cc
index a18fce2ea2..8fb91ec5f5 100644
--- a/src/records/RecCore.cc
+++ b/src/records/RecCore.cc
@@ -489,11 +489,11 @@ RecGetRecordBool(const char *name, RecBool *rec_bool, bool lock)
 RecErrT
 RecLookupRecord(const char *name, void (*callback)(const RecRecord *, void *), void *data, bool lock)
 {
-  RecErrT err              = REC_ERR_FAIL;
-  ts::Metrics &api_metrics = ts::Metrics::getInstance();
-  auto it                  = api_metrics.find(name);
+  RecErrT err       = REC_ERR_FAIL;
+  ts::Metrics &intm = ts::Metrics::getInstance();
+  auto it           = intm.find(name);
 
-  if (it != api_metrics.end()) {
+  if (it != intm.end()) {
     RecRecord r;
     auto &&[name, val] = *it;
 
@@ -536,18 +536,18 @@ RecLookupMatchingRecords(unsigned rec_type, const char *match, void (*callback)(
     return REC_ERR_FAIL;
   }
 
-  if (rec_type & RECT_PLUGIN) { // ToDo: This should change if we use the new metrics for core metrics
-    RecRecord r;
+  // First find the new metrics, this is a bit of a hack, beacuse we still use the old
+  // librecords callback with a "pseudo" record.
+  RecRecord tmp;
 
-    r.rec_type  = RECT_PLUGIN;
-    r.data_type = RECD_INT;
+  tmp.rec_type  = RECT_ALL;
+  tmp.data_type = RECD_INT;
 
-    for (auto &&[name, val] : ts::Metrics::getInstance()) {
-      if (regex.match(name.data()) >= 0) {
-        r.name         = name.data();
-        r.data.rec_int = val;
-        callback(&r, data);
-      }
+  for (auto &&[name, val] : ts::Metrics::getInstance()) {
+    if (regex.match(name.data()) >= 0) {
+      tmp.name         = name.data();
+      tmp.data.rec_int = val;
+      callback(&tmp, data);
     }
   }
 
@@ -1093,14 +1093,13 @@ RecDumpRecords(RecT rec_type, RecDumpEntryCb callback, void *edata)
       rec_mutex_release(&(r->lock));
     }
   }
-  // Also dump the new ts::Metrics if asked for
-  if (rec_type & RECT_PLUGIN) { // ToDo: This should change if we use the new metrics for core metrics
-    RecData datum;
 
-    for (auto &&[name, val] : ts::Metrics::getInstance()) {
-      datum.rec_int = val;
-      callback(RECT_PLUGIN, edata, true, name.data(), TS_RECORDDATATYPE_INT, &datum);
-    }
+  // Dump all new metrics as well (no "type" for them)
+  RecData datum;
+
+  for (auto &&[name, val] : ts::Metrics::getInstance()) {
+    datum.rec_int = val;
+    callback(RECT_PLUGIN, edata, true, name.data(), TS_RECORDDATATYPE_INT, &datum);
   }
 }