[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #3150: Support non-correlated subquery in having clause

[GitBox <gi...@apache.org>]

EmmyMiao87 commented on a change in pull request #3150: Support non-correlated subquery in having clause
URL: https://github.com/apache/incubator-doris/pull/3150#discussion_r397575808
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/analysis/SelectStmt.java
 ##########
 @@ -974,16 +1009,24 @@ private void analyzeAggregation(Analyzer analyzer) throws AnalysisException {
             LOG.debug("desctbl: " + analyzer.getDescTbl().debugString());
             LOG.debug("resultexprs: " + Expr.debugString(resultExprs));
         }
+        /*
+         * All of columns of result and having clause are replaced by new slot ref which is bound by top tuple of agg info.
+         * For example:
+         * ResultExprs: SlotRef(k1), FunctionCall(sum(SlotRef(k2)))
 
 Review comment:
   Em...The "after rewritten" is mean that after `Expr.substitueList ` as following. This commit is used to analyze what happen with this line ```resultExprs = Expr.substituteList(resultExprs, combinedSmap, analyzer, false);```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org