[GitHub] [spark] sarutak commented on a change in pull request #32214: [SPARK-35117][UI] Change progress bar back to highlight ratio of tasks in progress

[GitBox <gi...@apache.org>]

sarutak commented on a change in pull request #32214:
URL: https://github.com/apache/spark/pull/32214#discussion_r615828137



##########
File path: core/src/main/scala/org/apache/spark/ui/UIUtils.scala
##########
@@ -464,9 +464,10 @@ private[spark] object UIUtils extends Logging {
     val completeWidth = "width: %s%%".format(ratio)
     // started + completed can be > total when there are speculative tasks
     val boundedStarted = math.min(started, total - completed)
-    val startWidth = "width: %s%%".format((boundedStarted.toDouble/total)*100)
+    val startRatio = if (total == 0) 0.0 else (boundedStarted.toDouble/total)*100

Review comment:
       nit: Now that we touch this code, can we fix the style too like as follows?
   ```
   val startRatio = if (total == 0) 0.0 else (boundedStarted.toDouble / total) * 100




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org