You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/01 07:41:24 UTC

[GitHub] [pulsar] mattisonchao opened a new pull request, #17391: [fix][tests] PersistentStreamingDispatcherBlockConsumerTest#testBrokerSubscriptionRecovery

mattisonchao opened a new pull request, #17391:
URL: https://github.com/apache/pulsar/pull/17391

   
   ### Motivation
   
   test example: https://github.com/apache/pulsar/runs/8128077384?check_suite_focus=true
   
   We can expand read timeout to avoid missing messages.
   
   ### Modifications
   
   -Expand receive timeout from 500 million seconds to 10 seconds.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (yes / no)
     - The schema: (yes / no / don't know)
     - The default values of configurations: (yes / no)
     - The wire protocol: (yes / no)
     - The rest endpoints: (yes / no)
     - The admin cli options: (yes / no)
     - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [x] `doc-not-needed` 
   (Please explain why)
     
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] mattisonchao closed pull request #17391: [fix][tests] PersistentStreamingDispatcherBlockConsumerTest#testBrokerSubscriptionRecovery

Posted by GitBox <gi...@apache.org>.
mattisonchao closed pull request #17391: [fix][tests] PersistentStreamingDispatcherBlockConsumerTest#testBrokerSubscriptionRecovery
URL: https://github.com/apache/pulsar/pull/17391


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] mattisonchao commented on pull request #17391: [fix][tests] PersistentStreamingDispatcherBlockConsumerTest#testBrokerSubscriptionRecovery

Posted by GitBox <gi...@apache.org>.
mattisonchao commented on PR #17391:
URL: https://github.com/apache/pulsar/pull/17391#issuecomment-1235038377

   > Hi @mattisonchao
   > 
   > Sorry, I think it is not the root cause, I have submitted another PR to fix this flaky-test :
   > 
   > * #17418
   
   Got it, thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] poorbarcode commented on pull request #17391: [fix][tests] PersistentStreamingDispatcherBlockConsumerTest#testBrokerSubscriptionRecovery

Posted by GitBox <gi...@apache.org>.
poorbarcode commented on PR #17391:
URL: https://github.com/apache/pulsar/pull/17391#issuecomment-1235034874

   Hi @mattisonchao 
   
   Sorry, I think it is not the root cause, I have submitted another PR to fix this flaky-test : 
   
   - #17418


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org