You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Sangeeta Ravindran <sa...@gmail.com> on 2017/01/26 19:19:32 UTC

Review Request 55992: Workflow Manager: Path does not get set to selected directory when creating FS action node.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55992/
-----------------------------------------------------------

Review request for Ambari, Di Li, DIPAYAN BHOWMICK, and Nitiraj Rathore.


Bugs: AMBARI-19729
    https://issues.apache.org/jira/browse/AMBARI-19729


Repository: ambari


Description
-------

1. Try to add a FS node to a workflow. 
2. Browse and select a path and click on Select button. The Path field is still empty.

Error in the browser console:

Uncaught TypeError: Cannot set property 'path' of undefined
    at Object.u [as set] (vendor-4ae345a01092a915fe851b682258b76a.js:11)
    at n.<anonymous> (oozie-designer-21b647fc98ff652bc7cd154671c10e5b.js:5)
    at Object.f [as apply] (vendor-4ae345a01092a915fe851b682258b76a.js:11)
    at Object.d [as sendEvent] (vendor-4ae345a01092a915fe851b682258b76a.js:10)
    at n.trigger [as _super] (vendor-4ae345a01092a915fe851b682258b76a.js:14)
    at n.trigger (vendor-4ae345a01092a915fe851b682258b76a.js:16)
    at n [as trigger] (vendor-4ae345a01092a915fe851b682258b76a.js:11)
    at n.closeFileBrowser (oozie-designer-21b647fc98ff652bc7cd154671c10e5b.js:6)
    at n.send (vendor-4ae345a01092a915fe851b682258b76a.js:15)
    at n [as send] (vendor-4ae345a01092a915fe851b682258b76a.js:11)
    
With the changes in AMBARI-19332, the input field for directory path was updated to prep.path (was prep.settings.path before).


Diffs
-----

  contrib/views/wfmanager/src/main/resources/ui/app/components/prepare-config-fs.js ba9b91e 

Diff: https://reviews.apache.org/r/55992/diff/


Testing
-------

Tested manually.
Build failure is unrelated to the patch.


Thanks,

Sangeeta Ravindran

Re: Review Request 55992: Workflow Manager: Path does not get set to selected directory when creating FS action node.

Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55992/#review163164
-----------------------------------------------------------


Ship it!




Ship It!

- Di Li


On Jan. 26, 2017, 7:19 p.m., Sangeeta Ravindran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55992/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2017, 7:19 p.m.)
> 
> 
> Review request for Ambari, Di Li, DIPAYAN BHOWMICK, and Nitiraj Rathore.
> 
> 
> Bugs: AMBARI-19729
>     https://issues.apache.org/jira/browse/AMBARI-19729
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 1. Try to add a FS node to a workflow. 
> 2. Browse and select a path and click on Select button. The Path field is still empty.
> 
> Error in the browser console:
> 
> Uncaught TypeError: Cannot set property 'path' of undefined
>     at Object.u [as set] (vendor-4ae345a01092a915fe851b682258b76a.js:11)
>     at n.<anonymous> (oozie-designer-21b647fc98ff652bc7cd154671c10e5b.js:5)
>     at Object.f [as apply] (vendor-4ae345a01092a915fe851b682258b76a.js:11)
>     at Object.d [as sendEvent] (vendor-4ae345a01092a915fe851b682258b76a.js:10)
>     at n.trigger [as _super] (vendor-4ae345a01092a915fe851b682258b76a.js:14)
>     at n.trigger (vendor-4ae345a01092a915fe851b682258b76a.js:16)
>     at n [as trigger] (vendor-4ae345a01092a915fe851b682258b76a.js:11)
>     at n.closeFileBrowser (oozie-designer-21b647fc98ff652bc7cd154671c10e5b.js:6)
>     at n.send (vendor-4ae345a01092a915fe851b682258b76a.js:15)
>     at n [as send] (vendor-4ae345a01092a915fe851b682258b76a.js:11)
>     
> With the changes in AMBARI-19332, the input field for directory path was updated to prep.path (was prep.settings.path before).
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/prepare-config-fs.js ba9b91e 
> 
> Diff: https://reviews.apache.org/r/55992/diff/
> 
> 
> Testing
> -------
> 
> Tested manually.
> Build failure is unrelated to the patch.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 55992: Workflow Manager: Path does not get set to selected directory when creating FS action node.

Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55992/#review163163
-----------------------------------------------------------


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Jan. 26, 2017, 7:19 p.m., Sangeeta Ravindran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55992/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2017, 7:19 p.m.)
> 
> 
> Review request for Ambari, Di Li, DIPAYAN BHOWMICK, and Nitiraj Rathore.
> 
> 
> Bugs: AMBARI-19729
>     https://issues.apache.org/jira/browse/AMBARI-19729
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 1. Try to add a FS node to a workflow. 
> 2. Browse and select a path and click on Select button. The Path field is still empty.
> 
> Error in the browser console:
> 
> Uncaught TypeError: Cannot set property 'path' of undefined
>     at Object.u [as set] (vendor-4ae345a01092a915fe851b682258b76a.js:11)
>     at n.<anonymous> (oozie-designer-21b647fc98ff652bc7cd154671c10e5b.js:5)
>     at Object.f [as apply] (vendor-4ae345a01092a915fe851b682258b76a.js:11)
>     at Object.d [as sendEvent] (vendor-4ae345a01092a915fe851b682258b76a.js:10)
>     at n.trigger [as _super] (vendor-4ae345a01092a915fe851b682258b76a.js:14)
>     at n.trigger (vendor-4ae345a01092a915fe851b682258b76a.js:16)
>     at n [as trigger] (vendor-4ae345a01092a915fe851b682258b76a.js:11)
>     at n.closeFileBrowser (oozie-designer-21b647fc98ff652bc7cd154671c10e5b.js:6)
>     at n.send (vendor-4ae345a01092a915fe851b682258b76a.js:15)
>     at n [as send] (vendor-4ae345a01092a915fe851b682258b76a.js:11)
>     
> With the changes in AMBARI-19332, the input field for directory path was updated to prep.path (was prep.settings.path before).
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/prepare-config-fs.js ba9b91e 
> 
> Diff: https://reviews.apache.org/r/55992/diff/
> 
> 
> Testing
> -------
> 
> Tested manually.
> Build failure is unrelated to the patch.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>