You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/01/28 01:23:16 UTC

[GitHub] [geode-native] moleske opened a new pull request #732: Update to ace 7

moleske opened a new pull request #732:
URL: https://github.com/apache/geode-native/pull/732


   Authored-by: M. Oleske <mi...@oleske.engineer>
   
   I didn't really want to update ACE, but I really wanted to be able to [build on MacOS 11 (Big Sur)](https://github.com/moleske/geode-native/runs/1773671597?check_suite_focus=true) so 🤷‍♀️ 
   
   Seems to work in my tests for the existing operating systems, but will let folks with fancy pipelines tell me I'm wrong


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode-native] pdxcodemonkey commented on pull request #732: GEODE-8884: Update ACE to 7.0.0

Posted by GitBox <gi...@apache.org>.
pdxcodemonkey commented on pull request #732:
URL: https://github.com/apache/geode-native/pull/732#issuecomment-769890559


   Started up a "fancy pipeline", will approve/merge if all looks good.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode-native] moleske commented on pull request #732: Update to ace 7

Posted by GitBox <gi...@apache.org>.
moleske commented on pull request #732:
URL: https://github.com/apache/geode-native/pull/732#issuecomment-769352482


   We [bump](https://github.com/apache/geode-native/pull/701) [ACE](https://github.com/apache/geode-native/pull/599) [all](https://github.com/apache/geode-native/pull/590) [the](https://github.com/apache/geode-native/pull/565) [time](https://github.com/apache/geode-native/pull/492) [without](https://github.com/apache/geode-native/pull/426) [dev](https://github.com/apache/geode-native/pull/241) [list](https://github.com/apache/geode-native/pull/146) discussion to stay up to date.  Since we are still using ACE and there does not seem to be a long term support version of 6.x.x so updating will be necessary at some point.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode-native] codecov-io commented on pull request #732: GEODE-8884: Update ACE to 7.0.0

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #732:
URL: https://github.com/apache/geode-native/pull/732#issuecomment-769952889


   # [Codecov](https://codecov.io/gh/apache/geode-native/pull/732?src=pr&el=h1) Report
   > Merging [#732](https://codecov.io/gh/apache/geode-native/pull/732?src=pr&el=desc) (6e7072f) into [develop](https://codecov.io/gh/apache/geode-native/commit/a4afaf31d9739172171f82e90201dd13abd6e1e1?el=desc) (a4afaf3) will **decrease** coverage by `0.12%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/geode-native/pull/732/graphs/tree.svg?width=650&height=150&src=pr&token=plpAqoqGag)](https://codecov.io/gh/apache/geode-native/pull/732?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #732      +/-   ##
   ===========================================
   - Coverage    75.12%   75.00%   -0.13%     
   ===========================================
     Files          645      645              
     Lines        49763    49763              
   ===========================================
   - Hits         37386    37323      -63     
   - Misses       12377    12440      +63     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/geode-native/pull/732?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...tion-test/testThinClientRemoteQueryFailoverPdx.cpp](https://codecov.io/gh/apache/geode-native/pull/732/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC90ZXN0VGhpbkNsaWVudFJlbW90ZVF1ZXJ5RmFpbG92ZXJQZHguY3Bw) | `85.48% <0.00%> (-4.04%)` | :arrow_down: |
   | [...test/testThinClientPoolExecuteHAFunctionPrSHOP.cpp](https://codecov.io/gh/apache/geode-native/pull/732/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC90ZXN0VGhpbkNsaWVudFBvb2xFeGVjdXRlSEFGdW5jdGlvblByU0hPUC5jcHA=) | `91.20% <0.00%> (-3.71%)` | :arrow_down: |
   | [cppcache/src/ExceptionTypes.cpp](https://codecov.io/gh/apache/geode-native/pull/732/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0V4Y2VwdGlvblR5cGVzLmNwcA==) | `42.04% <0.00%> (-2.28%)` | :arrow_down: |
   | [cppcache/src/TcrMessage.hpp](https://codecov.io/gh/apache/geode-native/pull/732/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1Rjck1lc3NhZ2UuaHBw) | `98.00% <0.00%> (-2.00%)` | :arrow_down: |
   | [cppcache/src/CacheTransactionManagerImpl.cpp](https://codecov.io/gh/apache/geode-native/pull/732/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0NhY2hlVHJhbnNhY3Rpb25NYW5hZ2VySW1wbC5jcHA=) | `81.72% <0.00%> (-1.62%)` | :arrow_down: |
   | [cppcache/src/ThinClientPoolDM.cpp](https://codecov.io/gh/apache/geode-native/pull/732/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRQb29sRE0uY3Bw) | `76.30% <0.00%> (-1.20%)` | :arrow_down: |
   | [cppcache/src/RemoteQuery.cpp](https://codecov.io/gh/apache/geode-native/pull/732/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1JlbW90ZVF1ZXJ5LmNwcA==) | `78.02% <0.00%> (-1.10%)` | :arrow_down: |
   | [cppcache/src/TcrEndpoint.cpp](https://codecov.io/gh/apache/geode-native/pull/732/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckVuZHBvaW50LmNwcA==) | `57.44% <0.00%> (-1.07%)` | :arrow_down: |
   | [cppcache/src/ThinClientRedundancyManager.cpp](https://codecov.io/gh/apache/geode-native/pull/732/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRSZWR1bmRhbmN5TWFuYWdlci5jcHA=) | `76.12% <0.00%> (-0.84%)` | :arrow_down: |
   | [cppcache/include/geode/ExceptionTypes.hpp](https://codecov.io/gh/apache/geode-native/pull/732/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW5jbHVkZS9nZW9kZS9FeGNlcHRpb25UeXBlcy5ocHA=) | `39.04% <0.00%> (-0.80%)` | :arrow_down: |
   | ... and [5 more](https://codecov.io/gh/apache/geode-native/pull/732/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/geode-native/pull/732?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/geode-native/pull/732?src=pr&el=footer). Last update [a4afaf3...6e7072f](https://codecov.io/gh/apache/geode-native/pull/732?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode-native] pdxcodemonkey merged pull request #732: GEODE-8884: Update ACE to 7.0.0

Posted by GitBox <gi...@apache.org>.
pdxcodemonkey merged pull request #732:
URL: https://github.com/apache/geode-native/pull/732


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org