[GitHub] [hadoop-thirdparty] jojochuang commented on a change in pull request #14: HADOOP-17692. Update Hadoop-thirdparty release script

[GitBox <gi...@apache.org>]

jojochuang commented on a change in pull request #14:
URL: https://github.com/apache/hadoop-thirdparty/pull/14#discussion_r631526674



##########
File path: dev-support/docker/Dockerfile
##########
@@ -93,20 +94,8 @@ RUN apt-get -q update \
     && apt-get clean \
     && rm -rf /var/lib/apt/lists/*
 
-
-######
-# Install cmake 3.1.0 (3.5.1 ships with Xenial)
-######
-RUN mkdir -p /opt/cmake \
-    && curl -L -s -S \
-      https://cmake.org/files/v3.1/cmake-3.1.0-Linux-x86_64.tar.gz \
-      -o /opt/cmake.tar.gz \
-    && tar xzf /opt/cmake.tar.gz --strip-components 1 -C /opt/cmake
-ENV CMAKE_HOME /opt/cmake
-ENV PATH "${PATH}:/opt/cmake/bin"
-
 ######
-# Install Google Protobuf 3.7.1 (2.6.0 ships with Xenial)
+# Install Google Protobuf 3.7.1 (3.0.0 ships with Bionic)

Review comment:
       a! you're perfectly right. I kept thinking we shade protobuf so we need it. But we don't use protoc to compile proto files




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org