[GitHub] [brooklyn-server] zan-mateusz opened a new pull request #1183: [WIP] Feature - Terminated Node Deletion from persistence on startup

[GitBox <gi...@apache.org>]

zan-mateusz opened a new pull request #1183:
URL: https://github.com/apache/brooklyn-server/pull/1183


   Changes related to automatic terminated node removal on startup.
   Requirements:
   - new configuration property to specify threshold of inactivity after which terminated nodes are to be removed
   - nodes removed from persistence on startup of the server
   
   Implementation Notes:
   - property in 'brooklyn.cfg' added: brooklyn.ha.timeoutForInactiveNodeRemovalOnStartup
   - format of property is a duration, e.g 1h30m, 2d12h, 30s, etc.
   - loadSyncRecord() loads the management node data from persistence store. If property above is specified (not ZERO) and node is terminated, compares if its inactivity period is higher than threshold and if so, removes from the persistence store.
   - loadSyncRecord() is also periodically called during run so isStartup property introduced to ensure this code is fired only during startup
   
   Testing:
   - Tested locally:
   -- terminated nodes correctly removed after inactivity period expires
   -- terminated nodes correctly retained if inactivity period not exceeded
   -- no terminated nodes removed in case without property present in brooklyn.cfg
   -- non-terminated nodes correctly retained
   -- other active servers correctly updated in the HA Status table (about page) 
   -- tested as master and non-master nodes
   -- nodes are not removed as server is running (startup only)
   
   TODO
   - Would be nice to introduce a unit test for this. I think this would involve creating a persistence store and making up some nodes in terminated state and simulating startup? Not sure how feasible is that and need to investigate further, but some pointers would be helpful.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [brooklyn-server] iuliana merged pull request #1183: Feature - Terminated Node Deletion from persistence on startup

[GitBox <gi...@apache.org>]

iuliana merged pull request #1183:
URL: https://github.com/apache/brooklyn-server/pull/1183


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org