You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2014/09/17 00:45:40 UTC

[GitHub] incubator-brooklyn pull request: Task garbage collection

GitHub user ahgittin opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/167

    Task garbage collection

    improve how tasks are GC'd, to keep more and more varied -- see individual commits for details
    
    NB builds on #159 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ahgittin/incubator-brooklyn task-garbage-collection

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/167.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #167
    
----
commit 8a8879d4c6e5e08ab6d703c51109ed982d6a8872
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date:   2014-09-10T21:13:44Z

    serialize any objects as json, falling back to an object containing toString and error message if the object is not properly serializable

commit e9d412f0c65a2596ec5ed144ca489945c1b3e9a0
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date:   2014-09-12T21:45:46Z

    make js for displaying gui more consistent, using JSON.stringify rather than FormatJSON since the latter doesn't do quotes right, and stringifying activity tags

commit 761968e11646a1afea8a98b49bf1b3aa54374803
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date:   2014-09-12T21:46:04Z

    service failure detector is an enricher, in example

commit f6f9549f9028538dadce534139268afdbf98b4a4
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date:   2014-09-13T00:32:07Z

    change JSON serialization used by REST so that it looks at fields, ignoring getters, because getters can cause infinite loops,
    and fix a couple other places where JSON serialization was dodgy (streams, apidoc)

commit 9829b322ffe9a5f9acb2258fd81d8040e3c914fa
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date:   2014-09-15T08:02:45Z

    include UndeclaredThrowable as an exception which is not interesting, and whose nested exception should be preferred for the purpose of informing the user of root causes

commit 3431604fdbf258f2053391c66ecc9472c2afce97
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date:   2014-09-15T23:56:38Z

    Merge branch 'master' into json-serialize-anything

commit 643a3c523f2a6dde0174f63b2d9c8bc0f1a37d47
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date:   2014-09-16T09:06:28Z

    support for catching errors when resolving values, and test where time-limited access is passed in as a config value and retrieved

commit b52a6b4e46d6a0322cfad567f9fc5ab8ab5ea047
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date:   2014-09-16T20:12:39Z

    introduce WeaklyPresent in maybe using weak references, and use that for streams so that large streams attached to tasks don't cause leaks;
    also use a strongly typed tag for effector tasks, including entity information

commit 8516078da30b7acb77d205db56b624eb6af85cd4
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date:   2014-09-16T20:40:09Z

    big change to garbage collection, doing a much better job of keeping a balanced history of tasks -- the primary limit is now on tag,
    each tag is allowed to have by default 50 tasks; coupled with new EffectorCalllTag for entity+effector_name, this means we keep
    effector calls much longer. (the overall defaults have been increased also, for history to 30 days, and a new per-entity limit of 1000 tasks.)
    
    other miscellaneous cleanup to tasks also, fixing the leak for DST internal jobs, and simplifying how task-completion callbacks work
    (so attempting to get() a result in a callback will not deadlock!)

commit 5ad90ca67fa1d40ea0c520490c61ba7b8a4d8512
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date:   2014-09-16T22:30:08Z

    use an internal proxy on tasks so that sub-tasks submitted by the internal job show up as submitted by their parent,
    making it easier to GC the right things and show the right things in the dashboard;
    also tweak how sub-tasks are cleaned up.  works nicely in gui now!

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Task garbage collection

Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/167#issuecomment-56011828
  
    looks really good and useful. Tests are passing. Merging now!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Task garbage collection

Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/167#issuecomment-55894952
  
    rebased


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Task garbage collection

Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/167#issuecomment-55894001
  
    @ahgittin could you please rebase it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Task garbage collection

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/167


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---