You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2023/01/17 17:29:00 UTC

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #1532: IGNITE-18540 Fixed processing of the default distribution zone.

sanpwc commented on code in PR #1532:
URL: https://github.com/apache/ignite-3/pull/1532#discussion_r1072526295


##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -791,9 +813,19 @@ public boolean onUpdate(@NotNull WatchEvent evt) {
 
                             logicalTopology = newLogicalTopology;
 
-                            zonesConfiguration.distributionZones().value().namedListKeys()
+                            Stream.of(

Review Comment:
   I'd rather encapsulate all actions to be performed with zone  into some fooBar method and simply call fooBar for defaultZone and fooBar for all other zones from the list.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org