You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/11/08 21:05:27 UTC

[kudu-CR] macOS: fix compile error introduced by 141de3377e6bdd 

Hello Adar Dembo, Todd Lipcon,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/5009

to review the following change.

Change subject: macOS: fix compile error introduced by 141de3377e6bdd
......................................................................

macOS: fix compile error introduced by 141de3377e6bdd

Change-Id: Id2a9556810feeb3128b97d60afb18a2547e0af5c
---
M src/kudu/integration-tests/external_mini_cluster_fs_inspector.cc
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/5009/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5009
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id2a9556810feeb3128b97d60afb18a2547e0af5c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] macOS: fix compile error introduced by 141de3377e6bdd

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: macOS: fix compile error introduced by 141de3377e6bdd
......................................................................


macOS: fix compile error introduced by 141de3377e6bdd

Change-Id: Id2a9556810feeb3128b97d60afb18a2547e0af5c
Reviewed-on: http://gerrit.cloudera.org:8080/5009
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/external_mini_cluster_fs_inspector.cc
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5009
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id2a9556810feeb3128b97d60afb18a2547e0af5c
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] macOS: fix compile error introduced by 141de3377e6bdd

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: macOS: fix compile error introduced by 141de3377e6bdd
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5009/1/src/kudu/integration-tests/external_mini_cluster_fs_inspector.cc
File src/kudu/integration-tests/external_mini_cluster_fs_inspector.cc:

Line 187: int64_t ExternalMiniClusterFsInspector::GetTabletSuperBlockMTimeOrDie(
Hmm. Not your fault obviously, but I have some requests for other (small) changes here:

1) Could you drop the std:: prefix from std::string on L188?
2) Could you add a static MonoTime::FromTimeSpec() method that mirrors MonoTime::ToTimeSpec(), change this method to use it, and return a MonoTime here instead?


-- 
To view, visit http://gerrit.cloudera.org:8080/5009
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2a9556810feeb3128b97d60afb18a2547e0af5c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] macOS: fix compile error introduced by 141de3377e6bdd

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: macOS: fix compile error introduced by 141de3377e6bdd
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5009/1/src/kudu/integration-tests/external_mini_cluster_fs_inspector.cc
File src/kudu/integration-tests/external_mini_cluster_fs_inspector.cc:

Line 187: int64_t ExternalMiniClusterFsInspector::GetTabletSuperBlockMTimeOrDie(
> but this is a time-since-epoch whereas MonoTime is time-since-arbitrary-ref
1) done
2) going to hold off on this, since it's not strictly related and Todd's concern


-- 
To view, visit http://gerrit.cloudera.org:8080/5009
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2a9556810feeb3128b97d60afb18a2547e0af5c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] macOS: fix compile error introduced by 141de3377e6bdd

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: macOS: fix compile error introduced by 141de3377e6bdd
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5009
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2a9556810feeb3128b97d60afb18a2547e0af5c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] macOS: fix compile error introduced by 141de3377e6bdd

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Todd Lipcon,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5009

to look at the new patch set (#2).

Change subject: macOS: fix compile error introduced by 141de3377e6bdd
......................................................................

macOS: fix compile error introduced by 141de3377e6bdd

Change-Id: Id2a9556810feeb3128b97d60afb18a2547e0af5c
---
M src/kudu/integration-tests/external_mini_cluster_fs_inspector.cc
1 file changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/5009/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5009
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id2a9556810feeb3128b97d60afb18a2547e0af5c
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] macOS: fix compile error introduced by 141de3377e6bdd

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: macOS: fix compile error introduced by 141de3377e6bdd
......................................................................


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5009
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2a9556810feeb3128b97d60afb18a2547e0af5c
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] macOS: fix compile error introduced by 141de3377e6bdd

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: macOS: fix compile error introduced by 141de3377e6bdd
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5009/1/src/kudu/integration-tests/external_mini_cluster_fs_inspector.cc
File src/kudu/integration-tests/external_mini_cluster_fs_inspector.cc:

Line 187: int64_t ExternalMiniClusterFsInspector::GetTabletSuperBlockMTimeOrDie(
> Hmm. Not your fault obviously, but I have some requests for other (small) c
but this is a time-since-epoch whereas MonoTime is time-since-arbitrary-reference-point. It's just that timespec is somewhat overloaded in posix APIs.


-- 
To view, visit http://gerrit.cloudera.org:8080/5009
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2a9556810feeb3128b97d60afb18a2547e0af5c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes