You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/01/01 03:41:49 UTC

[GitHub] [incubator-shardingsphere] avalon566 commented on a change in pull request #3829: Fix Postgres execute error sql no response (#3129)

avalon566 commented on a change in pull request #3829: Fix Postgres execute error sql no response (#3129)
URL: https://github.com/apache/incubator-shardingsphere/pull/3829#discussion_r362301010
 
 

 ##########
 File path: sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/execute/MySQLComStmtExecuteExecutor.java
 ##########
 @@ -60,6 +60,8 @@
     
     private volatile boolean isQuery;
     
+    private volatile boolean hasError;
 
 Review comment:
   In PostgreSQL, if return an error response when execute sql, you should not write PostgreSQLCommandCompletePacket, so i add this flag. [diff](https://github.com/apache/incubator-shardingsphere/pull/3829/files#diff-9ed7b59514c0a038841321e90a278ddc)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services