[GitHub] [cassandra] dcapwell commented on a change in pull request #747: CircleCI should run cqlshlib tests

[GitBox <gi...@apache.org>]

dcapwell commented on a change in pull request #747:
URL: https://github.com/apache/cassandra/pull/747#discussion_r509687010



##########
File path: .circleci/config-2_1.yml
##########
@@ -28,6 +28,12 @@ j8_small_par_executor: &j8_small_par_executor
     #exec_resource_class: xlarge
   parallelism: 1
 
+j8_small_executor: &j8_small_executor
+  executor:
+    name: java8-executor
+    exec_resource_class: medium

Review comment:
       can we do `#exec_resource_class: xlarge` like the rest? No executor selects medium, they rely on default.

##########
File path: .circleci/config-2_1.yml
##########
@@ -202,6 +217,9 @@ j11_with_dtests_jobs: &j11_with_dtests_jobs
     - j11_jvm_dtests:
         requires:
           - j11_build
+    - j11_cqlshlib_tests:

Review comment:
       should we have an approval here?  j11 doesn't really run anything without explicit approval, this would run for all commits.

##########
File path: .circleci/config-2_1.yml
##########
@@ -28,6 +28,12 @@ j8_small_par_executor: &j8_small_par_executor
     #exec_resource_class: xlarge
   parallelism: 1
 
+j8_small_executor: &j8_small_executor

Review comment:
       nit, why not `j8_seq_executor`?  it exists and serves the same purpose.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org