You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Honghai Chen <Ho...@microsoft.com> on 2015/06/10 08:24:58 UTC

[VOTE] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

Hi Kafka,
                After a long discussion, please help vote again for the KIP. Thanks.


I wrote a KIP for this after some discussion on KAFKA-1646. https://issues.apache.org/jira/browse/KAFKA-1646

https://cwiki.apache.org/confluence/display/KAFKA/KIP-20+-+Enable+log+preallocate+to+improve+consume+performance+under+windows+and+some+old+Linux+file+system

The RB is here: https://reviews.apache.org/r/33204/diff/4/


Thanks,
Honghai Chen


Re: [VOTE] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

Posted by Jun Rao <ju...@confluent.io>.
+1

Thanks,

Jun

On Tue, Jun 9, 2015 at 11:24 PM, Honghai Chen <Ho...@microsoft.com>
wrote:

>  Hi Kafka,
>
>                 After a long discussion, please help vote again for the
> KIP. Thanks.
>
>
>
> I wrote a KIP for this after some discussion on KAFKA-1646.
> https://issues.apache.org/jira/browse/KAFKA-1646
>
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-20+-+Enable+log+preallocate+to+improve+consume+performance+under+windows+and+some+old+Linux+file+system
>
> The RB is here: https://reviews.apache.org/r/33204/diff/4/
>
>
>
>
>
> Thanks,
>
> Honghai Chen
>
>
>

RE: [VOTE] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

Posted by Honghai Chen <Ho...@microsoft.com>.
Fix done, update code review, and patch in jira.  

Thanks,  
Honghai Chen

-----Original Message-----
From: Jun Rao [mailto:jun@confluent.io] 
Sent: Tuesday, June 16, 2015 6:03 AM
To: dev@kafka.apache.org
Subject: Re: [VOTE] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

Hi, Honghai,

I left some comments on the RB in KAFKA-1646. Have you seen those yet?

Thanks,

Jun

On Mon, Jun 15, 2015 at 12:58 AM, Honghai Chen <Ho...@microsoft.com>
wrote:

> Hi Jay,
>         Seemly we met the "Lazy majority " rule, push it?
>
> Binding +5
>         Jun Rao
>         Neha
>         Jakob
>         Jay Kreps
>         Sriram Subramanian
>
> Non-binding  +2
>         Gwen Shapira
>         JG Homan
>
> Thanks,
> Honghai Chen
>
> -----Original Message-----
> From: Neha Narkhede [mailto:neha@confluent.io]
> Sent: Thursday, June 11, 2015 3:54 AM
> To: dev@kafka.apache.org
> Subject: Re: [VOTE] KIP 20 Enable log preallocate to improve consume 
> performance under windows and some old Linux file system
>
> +1
>
> On Wed, Jun 10, 2015 at 11:45 AM, Jakob Homan <jg...@gmail.com> wrote:
>
> > +1
> >
> >
> >
> > > On Jun 10, 2015, at 10:36 AM, JG Homan <jg...@gmail.com> wrote:
> > >
> > > +1
> > >
> > > On Wed, Jun 10, 2015 at 10:12 AM, Gwen Shapira 
> > > <gs...@cloudera.com>
> > wrote:
> > > +1 (non-binding)
> > >
> > > On Tue, Jun 9, 2015 at 11:24 PM, Honghai Chen 
> > > <Ho...@microsoft.com> wrote:
> > > > Hi Kafka,
> > > >
> > > > After a long discussion, please help vote again for the KIP.
> > > > Thanks.
> > > >
> > > >
> > > >
> > > > I wrote a KIP for this after some discussion on KAFKA-1646.
> > > > https://issues.apache.org/jira/browse/KAFKA-1646
> > > >
> > > >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-20+-+Enable+lo
> > g+
> > preallocate+to+improve+consume+performance+under+windows+and+some+old+
> > Linux+file+system
> > > >
> > > > The RB is here: https://reviews.apache.org/r/33204/diff/4/
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > Thanks,
> > > >
> > > > Honghai Chen
> > > >
> > > >
> >
>
>
>
> --
> Thanks,
> Neha
>

Re: [VOTE] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

Posted by Jun Rao <ju...@confluent.io>.
Hi, Honghai,

I left some comments on the RB in KAFKA-1646. Have you seen those yet?

Thanks,

Jun

On Mon, Jun 15, 2015 at 12:58 AM, Honghai Chen <Ho...@microsoft.com>
wrote:

> Hi Jay,
>         Seemly we met the "Lazy majority " rule, push it?
>
> Binding +5
>         Jun Rao
>         Neha
>         Jakob
>         Jay Kreps
>         Sriram Subramanian
>
> Non-binding  +2
>         Gwen Shapira
>         JG Homan
>
> Thanks,
> Honghai Chen
>
> -----Original Message-----
> From: Neha Narkhede [mailto:neha@confluent.io]
> Sent: Thursday, June 11, 2015 3:54 AM
> To: dev@kafka.apache.org
> Subject: Re: [VOTE] KIP 20 Enable log preallocate to improve consume
> performance under windows and some old Linux file system
>
> +1
>
> On Wed, Jun 10, 2015 at 11:45 AM, Jakob Homan <jg...@gmail.com> wrote:
>
> > +1
> >
> >
> >
> > > On Jun 10, 2015, at 10:36 AM, JG Homan <jg...@gmail.com> wrote:
> > >
> > > +1
> > >
> > > On Wed, Jun 10, 2015 at 10:12 AM, Gwen Shapira
> > > <gs...@cloudera.com>
> > wrote:
> > > +1 (non-binding)
> > >
> > > On Tue, Jun 9, 2015 at 11:24 PM, Honghai Chen
> > > <Ho...@microsoft.com> wrote:
> > > > Hi Kafka,
> > > >
> > > > After a long discussion, please help vote again for the KIP.
> > > > Thanks.
> > > >
> > > >
> > > >
> > > > I wrote a KIP for this after some discussion on KAFKA-1646.
> > > > https://issues.apache.org/jira/browse/KAFKA-1646
> > > >
> > > >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-20+-+Enable+log+
> > preallocate+to+improve+consume+performance+under+windows+and+some+old+
> > Linux+file+system
> > > >
> > > > The RB is here: https://reviews.apache.org/r/33204/diff/4/
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > Thanks,
> > > >
> > > > Honghai Chen
> > > >
> > > >
> >
>
>
>
> --
> Thanks,
> Neha
>

RE: [VOTE] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

Posted by Honghai Chen <Ho...@microsoft.com>.
Hi Jay,
	Seemly we met the "Lazy majority " rule, push it?

Binding +5
	Jun Rao
	Neha
	Jakob
	Jay Kreps
	Sriram Subramanian

Non-binding  +2
	Gwen Shapira
	JG Homan

Thanks,  
Honghai Chen

-----Original Message-----
From: Neha Narkhede [mailto:neha@confluent.io] 
Sent: Thursday, June 11, 2015 3:54 AM
To: dev@kafka.apache.org
Subject: Re: [VOTE] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

+1

On Wed, Jun 10, 2015 at 11:45 AM, Jakob Homan <jg...@gmail.com> wrote:

> +1
>
>
>
> > On Jun 10, 2015, at 10:36 AM, JG Homan <jg...@gmail.com> wrote:
> >
> > +1
> >
> > On Wed, Jun 10, 2015 at 10:12 AM, Gwen Shapira 
> > <gs...@cloudera.com>
> wrote:
> > +1 (non-binding)
> >
> > On Tue, Jun 9, 2015 at 11:24 PM, Honghai Chen 
> > <Ho...@microsoft.com> wrote:
> > > Hi Kafka,
> > >
> > > After a long discussion, please help vote again for the KIP.
> > > Thanks.
> > >
> > >
> > >
> > > I wrote a KIP for this after some discussion on KAFKA-1646.
> > > https://issues.apache.org/jira/browse/KAFKA-1646
> > >
> > >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-20+-+Enable+log+
> preallocate+to+improve+consume+performance+under+windows+and+some+old+
> Linux+file+system
> > >
> > > The RB is here: https://reviews.apache.org/r/33204/diff/4/
> > >
> > >
> > >
> > >
> > >
> > > Thanks,
> > >
> > > Honghai Chen
> > >
> > >
>



--
Thanks,
Neha

Re: [VOTE] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

Posted by Neha Narkhede <ne...@confluent.io>.
+1

On Wed, Jun 10, 2015 at 11:45 AM, Jakob Homan <jg...@gmail.com> wrote:

> +1
>
>
>
> > On Jun 10, 2015, at 10:36 AM, JG Homan <jg...@gmail.com> wrote:
> >
> > +1
> >
> > On Wed, Jun 10, 2015 at 10:12 AM, Gwen Shapira <gs...@cloudera.com>
> wrote:
> > +1 (non-binding)
> >
> > On Tue, Jun 9, 2015 at 11:24 PM, Honghai Chen
> > <Ho...@microsoft.com> wrote:
> > > Hi Kafka,
> > >
> > > After a long discussion, please help vote again for the KIP.
> > > Thanks.
> > >
> > >
> > >
> > > I wrote a KIP for this after some discussion on KAFKA-1646.
> > > https://issues.apache.org/jira/browse/KAFKA-1646
> > >
> > >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-20+-+Enable+log+preallocate+to+improve+consume+performance+under+windows+and+some+old+Linux+file+system
> > >
> > > The RB is here: https://reviews.apache.org/r/33204/diff/4/
> > >
> > >
> > >
> > >
> > >
> > > Thanks,
> > >
> > > Honghai Chen
> > >
> > >
>



-- 
Thanks,
Neha

Re: [VOTE] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

Posted by Jakob Homan <jg...@gmail.com>.
+1



> On Jun 10, 2015, at 10:36 AM, JG Homan <jg...@gmail.com> wrote:
> 
> +1 
> 
> On Wed, Jun 10, 2015 at 10:12 AM, Gwen Shapira <gs...@cloudera.com> wrote:
> +1 (non-binding)
> 
> On Tue, Jun 9, 2015 at 11:24 PM, Honghai Chen
> <Ho...@microsoft.com> wrote:
> > Hi Kafka,
> >
> > After a long discussion, please help vote again for the KIP.
> > Thanks.
> >
> >
> >
> > I wrote a KIP for this after some discussion on KAFKA-1646.
> > https://issues.apache.org/jira/browse/KAFKA-1646
> >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-20+-+Enable+log+preallocate+to+improve+consume+performance+under+windows+and+some+old+Linux+file+system
> >
> > The RB is here: https://reviews.apache.org/r/33204/diff/4/
> >
> >
> >
> >
> >
> > Thanks,
> >
> > Honghai Chen
> >
> >

Re: [VOTE] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

Posted by JG Homan <jg...@gmail.com>.
+1

On Wed, Jun 10, 2015 at 10:12 AM, Gwen Shapira <gs...@cloudera.com> 
wrote:
+1 (non-binding)

On Tue, Jun 9, 2015 at 11:24 PM, Honghai Chen
<Ho...@microsoft.com> wrote:
 > Hi Kafka,
 >
 > After a long discussion, please help vote again for the KIP.
 > Thanks.
 >
 >
 >
 > I wrote a KIP for this after some discussion on KAFKA-1646.
 > https://issues.apache.org/jira/browse/KAFKA-1646
 >
 >
https://cwiki.apache.org/confluence/display/KAFKA/KIP-20+-+Enable+log+preallocate+to+improve+consume+performance+under+windows+and+some+old+Linux+file+system
 >
 > The RB is here: https://reviews.apache.org/r/33204/diff/4/
 >
 >
 >
 >
 >
 > Thanks,
 >
 > Honghai Chen
 >
 >

Re: [VOTE] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

Posted by Gwen Shapira <gs...@cloudera.com>.
+1 (non-binding)

On Tue, Jun 9, 2015 at 11:24 PM, Honghai Chen
<Ho...@microsoft.com> wrote:
> Hi Kafka,
>
>                 After a long discussion, please help vote again for the KIP.
> Thanks.
>
>
>
> I wrote a KIP for this after some discussion on KAFKA-1646.
> https://issues.apache.org/jira/browse/KAFKA-1646
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-20+-+Enable+log+preallocate+to+improve+consume+performance+under+windows+and+some+old+Linux+file+system
>
> The RB is here: https://reviews.apache.org/r/33204/diff/4/
>
>
>
>
>
> Thanks,
>
> Honghai Chen
>
>

Re: [VOTE] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

Posted by Sriram Subramanian <sr...@linkedin.com.INVALID>.
+1


> On Jun 10, 2015, at 9:38 AM, Jay Kreps <ja...@confluent.io> wrote:
> 
> +1
> 
> On Tue, Jun 9, 2015 at 11:24 PM, Honghai Chen <Ho...@microsoft.com>
> wrote:
> 
>> Hi Kafka,
>> 
>>                After a long discussion, please help vote again for the
>> KIP. Thanks.
>> 
>> 
>> 
>> I wrote a KIP for this after some discussion on KAFKA-1646.
>> https://issues.apache.org/jira/browse/KAFKA-1646
>> 
>> 
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-20+-+Enable+log+preallocate+to+improve+consume+performance+under+windows+and+some+old+Linux+file+system
>> 
>> The RB is here: https://reviews.apache.org/r/33204/diff/4/
>> 
>> 
>> 
>> 
>> 
>> Thanks,
>> 
>> Honghai Chen
>> 
>> 
>> 

Re: [VOTE] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

Posted by Jay Kreps <ja...@confluent.io>.
+1

On Tue, Jun 9, 2015 at 11:24 PM, Honghai Chen <Ho...@microsoft.com>
wrote:

>  Hi Kafka,
>
>                 After a long discussion, please help vote again for the
> KIP. Thanks.
>
>
>
> I wrote a KIP for this after some discussion on KAFKA-1646.
> https://issues.apache.org/jira/browse/KAFKA-1646
>
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-20+-+Enable+log+preallocate+to+improve+consume+performance+under+windows+and+some+old+Linux+file+system
>
> The RB is here: https://reviews.apache.org/r/33204/diff/4/
>
>
>
>
>
> Thanks,
>
> Honghai Chen
>
>
>