You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spamassassin.apache.org by qu...@apache.org on 2005/05/04 13:28:02 UTC
svn commit: r168114 - /spamassassin/trunk/t/gtube.t
Author: quinlan
Date: Wed May 4 04:28:00 2005
New Revision: 168114
URL: http://svn.apache.org/viewcvs?rev=168114&view=rev
Log:
these lines should be protected
Modified:
spamassassin/trunk/t/gtube.t
Modified: spamassassin/trunk/t/gtube.t
URL: http://svn.apache.org/viewcvs/spamassassin/trunk/t/gtube.t?rev=168114&r1=168113&r2=168114&view=diff
==============================================================================
--- spamassassin/trunk/t/gtube.t (original)
+++ spamassassin/trunk/t/gtube.t Wed May 4 04:28:00 2005
@@ -14,9 +14,12 @@
tstprefs ("
$default_cf_lines
- use_auto_whitelist 1
+
+ ifplugin Mail::Spamassassin:AWL
+ use_auto_whitelist 1
auto_whitelist_path ./log/awl
auto_whitelist_file_mode 0755
+ endif
");
ok (sarun ("-L -t < data/spam/gtube.eml", \&patterns_run_cb));
Re: svn commit: r168114 - /spamassassin/trunk/t/gtube.t
Posted by Daniel Quinlan <qu...@pathname.com>.
Michael Parker <pa...@pobox.com> writes:
> Hmmmm....we need some sort of init.pre parser that can parse the file
> and then we can query a hash or something else to determine if a
> particular test should be run.
>
> Let me know when you've got it done :)
Well, it may not be pretty, but the AWL change to gtube.t do fix the
gtube failures due to commenting out AWL in init.pre.
Daniel
--
Daniel Quinlan
http://www.pathname.com/~quinlan/
Re: svn commit: r168114 - /spamassassin/trunk/t/gtube.t
Posted by Michael Parker <pa...@pobox.com>.
On Wed, May 04, 2005 at 12:02:04PM -0700, Daniel Quinlan wrote:
>
> Hmmm... maybe it would be better to skip the test if the plugin is not
> loaded.
>
Hmmmm....we need some sort of init.pre parser that can parse the file
and then we can query a hash or something else to determine if a
particular test should be run.
Let me know when you've got it done :)
Michael
Re: svn commit: r168114 - /spamassassin/trunk/t/gtube.t
Posted by Daniel Quinlan <qu...@pathname.com>.
Michael Parker <pa...@pobox.com> writes:
> It should be Mail::SpamAssassin::Plugin::AWL, but besides that I'm not
> clear on why it's even necessary.
I commented out AWL in my init.pre and it caused the test to fail and/or
complain.
> Why not put it in the default location like every other test does?
> Plus, why would you not have the plugin loaded for this test because
> it explicitly tests that capability (ie gtube doesn't trigger bad AWL
> results).
Hmmm... maybe it would be better to skip the test if the plugin is not
loaded.
--
Daniel Quinlan
http://www.pathname.com/~quinlan/
Re: svn commit: r168114 - /spamassassin/trunk/t/gtube.t
Posted by Michael Parker <pa...@pobox.com>.
On Wed, May 04, 2005 at 11:28:02AM -0000, quinlan@apache.org wrote:
> $default_cf_lines
> - use_auto_whitelist 1
> +
> + ifplugin Mail::Spamassassin:AWL
> + use_auto_whitelist 1
> auto_whitelist_path ./log/awl
> auto_whitelist_file_mode 0755
> + endif
It should be Mail::SpamAssassin::Plugin::AWL, but besides that I'm not
clear on why it's even necessary. Why not put it in the default
location like every other test does? Plus, why would you not have the
plugin loaded for this test because it explicitly tests that
capability (ie gtube doesn't trigger bad AWL results).
Michael