You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2021/12/19 09:56:12 UTC
[GitHub] [jena] LorenzBuehmann opened a new pull request #1137: JENA-2225: Handle large datasets size in TDB stats serializer
LorenzBuehmann opened a new pull request #1137:
URL: https://github.com/apache/jena/pull/1137
This PR should fix the issue with serializing the size of a dataset in the TDB/TDB2 stats which failed for larger datasets beyond `int` value space.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on a change in pull request #1137: JENA-2225: Handle large datasets size in TDB stats serializer
Posted by GitBox <gi...@apache.org>.
afs commented on a change in pull request #1137:
URL: https://github.com/apache/jena/pull/1137#discussion_r771940191
##########
File path: jena-db/jena-tdb2/src/main/java/org/apache/jena/tdb2/solver/stats/Stats.java
##########
@@ -103,7 +105,7 @@ private static Item format(Map<Node, Integer> predicates, Map<Node, Integer> typ
addPair(meta.getList(), "timestamp", NodeFactoryExtra.nowAsDateTime());
addPair(meta.getList(), "run@", DateTimeUtils.nowAsString());
if ( count >= 0 )
- addPair(meta.getList(), StatsMatcher.COUNT, NodeFactoryExtra.intToNode((int)count));
Review comment:
The problem is the cast.
`NodeFactoryExtra.intToNode(count)` should work. `intToNode(long integer)` exists.
They both return an xsd:integer which is a better choice than xsd:long because, if nothing else, it prints nicely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs closed pull request #1137: JENA-2225: Handle large datasets size in TDB stats serializer
Posted by GitBox <gi...@apache.org>.
afs closed pull request #1137:
URL: https://github.com/apache/jena/pull/1137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #1137: JENA-2225: Handle large datasets size in TDB stats serializer
Posted by GitBox <gi...@apache.org>.
afs commented on pull request #1137:
URL: https://github.com/apache/jena/pull/1137#issuecomment-1001662925
Thanks.
A fix is included in #1143.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org