You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2019/10/30 22:58:36 UTC

[GitHub] [helix] narendly commented on a change in pull request #558: New module hosting Helix Zookeeper access logic

narendly commented on a change in pull request #558: New module hosting Helix Zookeeper access logic
URL: https://github.com/apache/helix/pull/558#discussion_r340896569
 
 

 ##########
 File path: helix-core/pom.xml
 ##########
 @@ -159,6 +159,10 @@ under the License.
       <artifactId>metrics-core</artifactId>
       <version>3.2.3</version>
     </dependency>
+    <dependency>
+      <groupId>org.apache.helix</groupId>
+      <artifactId>helix-zk</artifactId>
 
 Review comment:
   Do we really want to call it "helix-zk"? I thought the idea was to have a module fully decoupled from Helix's logic. In that case, names like "zookeeper-core" or "zk-api" might be more appropriate?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org