You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/20 14:09:01 UTC
[GitHub] [arrow] lidavidm opened a new pull request, #12937: ARROW-14577: [C++] Fix nullptr dereference when pre-buffering IPC reads
lidavidm opened a new pull request, #12937:
URL: https://github.com/apache/arrow/pull/12937
This fixes a bug when coalescing is enabled. Also, it changes the conditional so that we *skip* coalescing for zero-copy files instead of enabling it. Finally, it slightly refactors the tests to ensure this case is hit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12937: ARROW-16238: [C++] Fix nullptr dereference when pre-buffering IPC reads
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12937:
URL: https://github.com/apache/arrow/pull/12937#issuecomment-1104116523
https://issues.apache.org/jira/browse/ARROW-16238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #12937: ARROW-16238: [C++] Fix nullptr dereference when pre-buffering IPC reads
Posted by GitBox <gi...@apache.org>.
lidavidm commented on code in PR #12937:
URL: https://github.com/apache/arrow/pull/12937#discussion_r856378066
##########
cpp/src/arrow/ipc/read_write_test.cc:
##########
@@ -1456,8 +1477,13 @@ class ReaderWriterMixin : public ExtensionTypesMixin {
class TestFileFormat : public ReaderWriterMixin<FileWriterHelper>,
public ::testing::TestWithParam<MakeRecordBatch*> {};
-class TestFileFormatGenerator : public ReaderWriterMixin<FileGeneratorWriterHelper>,
- public ::testing::TestWithParam<MakeRecordBatch*> {};
+class TestFileFormatGenerator
+ : public ReaderWriterMixin<FileGeneratorWriterHelper</*kCoalesce=*/false>>,
+ public ::testing::TestWithParam<MakeRecordBatch*> {};
+
+class TestFileFormatCoalesced
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12937: ARROW-16238: [C++] Fix nullptr dereference when pre-buffering IPC reads
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12937:
URL: https://github.com/apache/arrow/pull/12937#issuecomment-1104060474
https://issues.apache.org/jira/browse/ARROW-14577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12937: ARROW-16238: [C++] Fix nullptr dereference when pre-buffering IPC reads
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #12937:
URL: https://github.com/apache/arrow/pull/12937#issuecomment-1112110436
Benchmark runs are scheduled for baseline = 40c1226f725dd70816c85b5a26635edba0f0fb45 and contender = fd5f28ec8b73904cc8291fc9d7ee24d1fb0231b6. fd5f28ec8b73904cc8291fc9d7ee24d1fb0231b6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/b5981fc1af4e4f74ae2e29b9795d0dee...be39e69b5f234270a34d6bfe3a863171/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/347208c1aee644839ee44c2d90861d38...01c1cd149734480b9ee15b3cc9b65c18/)
[Finished :arrow_down:0.36% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/570880ce1aa04b65a279f36bbc39ed67...b67f3b81dafa4620a781cbdfbe827801/)
[Finished :arrow_down:0.5% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/2a34ad2347e24c2c993f0d4a095157a1...6731a6b89b9d45b4a4b9c8c9259d2af4/)
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/609| `fd5f28ec` ec2-t3-xlarge-us-east-2>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/597| `fd5f28ec` test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/596| `fd5f28ec` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/607| `fd5f28ec` ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/608| `40c1226f` ec2-t3-xlarge-us-east-2>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/596| `40c1226f` test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/595| `40c1226f` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/606| `40c1226f` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on a diff in pull request #12937: ARROW-16238: [C++] Fix nullptr dereference when pre-buffering IPC reads
Posted by GitBox <gi...@apache.org>.
westonpace commented on code in PR #12937:
URL: https://github.com/apache/arrow/pull/12937#discussion_r856339323
##########
cpp/src/arrow/ipc/read_write_test.cc:
##########
@@ -1456,8 +1477,13 @@ class ReaderWriterMixin : public ExtensionTypesMixin {
class TestFileFormat : public ReaderWriterMixin<FileWriterHelper>,
public ::testing::TestWithParam<MakeRecordBatch*> {};
-class TestFileFormatGenerator : public ReaderWriterMixin<FileGeneratorWriterHelper>,
- public ::testing::TestWithParam<MakeRecordBatch*> {};
+class TestFileFormatGenerator
+ : public ReaderWriterMixin<FileGeneratorWriterHelper</*kCoalesce=*/false>>,
+ public ::testing::TestWithParam<MakeRecordBatch*> {};
+
+class TestFileFormatCoalesced
Review Comment:
Minor nit: Maybe `TestFileFormatGeneratorCoalesced`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs closed pull request #12937: ARROW-16238: [C++] Fix nullptr dereference when pre-buffering IPC reads
Posted by GitBox <gi...@apache.org>.
kszucs closed pull request #12937: ARROW-16238: [C++] Fix nullptr dereference when pre-buffering IPC reads
URL: https://github.com/apache/arrow/pull/12937
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org