You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/25 03:36:30 UTC
[GitHub] [inlong] e-mhui opened a new pull request, #5690: [INLONG-5689][Manager] PulsarSource set fieldDelimiter when use CSV format
e-mhui opened a new pull request, #5690:
URL: https://github.com/apache/inlong/pull/5690
### Prepare a Pull Request
[INLONG-5689][Manager] PulsarSource set fieldDelimiter when use CSV format
- Fixes #5689
### Motivation
PulsarSource set fieldDelimiter when use CSV format
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] e-mhui commented on a diff in pull request #5690: [INLONG-5689][Manager] PulsarSource set fieldDelimiter when use CSV format
Posted by GitBox <gi...@apache.org>.
e-mhui commented on code in PR #5690:
URL: https://github.com/apache/inlong/pull/5690#discussion_r954541642
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/source/pulsar/PulsarSourceOperator.java:
##########
@@ -142,6 +142,10 @@ public Map<String, List<StreamSource>> getSourcesMap(InlongGroupInfo groupInfo,
&& StringUtils.isNotEmpty(sourceInfo.getSerializationType())) {
pulsarSource.setSerializationType(sourceInfo.getSerializationType());
}
+ if (DataTypeEnum.CSV.getName().equalsIgnoreCase(pulsarSource.getSerializationType())) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #5690: [INLONG-5689][Manager] PulsarSource set fieldDelimiter when use CSV format
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #5690:
URL: https://github.com/apache/inlong/pull/5690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #5690: [INLONG-5689][Manager] PulsarSource set fieldDelimiter when use CSV format
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5690:
URL: https://github.com/apache/inlong/pull/5690#discussion_r954536356
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/source/pulsar/PulsarSourceOperator.java:
##########
@@ -142,6 +142,10 @@ public Map<String, List<StreamSource>> getSourcesMap(InlongGroupInfo groupInfo,
&& StringUtils.isNotEmpty(sourceInfo.getSerializationType())) {
pulsarSource.setSerializationType(sourceInfo.getSerializationType());
}
+ if (DataTypeEnum.CSV.getName().equalsIgnoreCase(pulsarSource.getSerializationType())) {
Review Comment:
Suggested move to the out of `for` loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #5690: [INLONG-5689][Manager] PulsarSource set fieldDelimiter when use CSV format
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5690:
URL: https://github.com/apache/inlong/pull/5690#discussion_r954534285
##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/consts/InlongConstants.java:
##########
@@ -66,6 +66,8 @@ public class InlongConstants {
public static final String PULSAR_QUEUE_TYPE_PARALLEL = "PARALLEL";
+ public static final String PULSAR_CSV_FIELDDELIMITER = "fieldDelimiter";
Review Comment:
Suggested changing to `FIELD_DELIMITER`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] e-mhui commented on a diff in pull request #5690: [INLONG-5689][Manager] PulsarSource set fieldDelimiter when use CSV format
Posted by GitBox <gi...@apache.org>.
e-mhui commented on code in PR #5690:
URL: https://github.com/apache/inlong/pull/5690#discussion_r954538904
##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/consts/InlongConstants.java:
##########
@@ -66,6 +66,8 @@ public class InlongConstants {
public static final String PULSAR_QUEUE_TYPE_PARALLEL = "PARALLEL";
+ public static final String PULSAR_CSV_FIELDDELIMITER = "fieldDelimiter";
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org