[GitHub] [spark] dongjoon-hyun commented on a change in pull request #26757: [SPARK-30121][Build] Fix memory usage in sbt build script

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #26757: [SPARK-30121][Build] Fix memory usage in sbt build script
URL: https://github.com/apache/spark/pull/26757#discussion_r354107486
 
 

 ##########
 File path: build/sbt
 ##########
 @@ -66,7 +66,7 @@ Usage: $script_name [options]
   -sbt-dir   <path>  path to global settings/plugins directory (default: ~/.sbt)
   -sbt-boot  <path>  path to shared boot directory (default: ~/.sbt/boot in 0.11 series)
   -ivy       <path>  path to local Ivy repository (default: ~/.ivy2)
-  -mem    <integer>  set memory options (default: $sbt_mem, which is $(get_mem_opts $sbt_mem))
+  -mem    <integer>  set memory options (default: $sbt_default_mem, which is $(get_mem_opts $sbt_default_mem))
 
 Review comment:
   If this PR aims to resync with `SBT 1.3.4`, shall we remove `get_mem_opts` function and `, which is $(get_mem_opts $sbt_default_mem)`  part completely.
   
   **SBT 0.13.18**
   ```
   $ ./sbt -h | grep mem
     -mem    <integer>  set memory options (default: 1024, which is -Xms1024m -Xmx1024m -XX:ReservedCodeCacheSize=128m -XX:MaxMetaspaceSize=256m)
   ```
   
   **SBT 1.3.4**
   ```
   $ bin/sbt -h | grep mem
     --mem    <integer>  set memory options (default: 1024)
   ```
   
   SBT 1.3.4 doesn't have `get_mem_opts` at all.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org