You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "zeroshade (via GitHub)" <gi...@apache.org> on 2023/06/21 14:58:17 UTC
[GitHub] [arrow-adbc] zeroshade opened a new pull request, #829: ci: Add CODEOWNERS file
zeroshade opened a new pull request, #829:
URL: https://github.com/apache/arrow-adbc/pull/829
Adding a CODEOWNERS file for auto assigning reviewers on PRs. Feel free to update, add, modify names and assignments here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] WillAyd commented on a diff in pull request #829: ci: Add CODEOWNERS file
Posted by "WillAyd (via GitHub)" <gi...@apache.org>.
WillAyd commented on code in PR #829:
URL: https://github.com/apache/arrow-adbc/pull/829#discussion_r1237338056
##########
.github/CODEOWNERS:
##########
@@ -0,0 +1,54 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+# Any committer can add themselves to any of the path patterns
+# and will subsequently get requested as a reviewer for any PRs
+# that change matching files.
+#
+# This file uses .gitignore syntax with a few exceptions see the
+# documentation about the syntax: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
+
+## Format
+adbc.h @lidavidm
+
+## Implementations
+/c/ @lidavidm @WillAyd
+/csharp/ @CurtHagenlocher @davidhcoe
Review Comment:
Strangely enough this still might have pinged me? Unless someone did so in a comment then edited out not sure why I would have been notified by GH
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] zeroshade commented on pull request #829: ci: Add CODEOWNERS file
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #829:
URL: https://github.com/apache/arrow-adbc/pull/829#issuecomment-1600999280
CC @WillAyd @davidhcoe @CurtHagenlocher
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] zeroshade commented on a diff in pull request #829: ci: Add CODEOWNERS file
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #829:
URL: https://github.com/apache/arrow-adbc/pull/829#discussion_r1237571638
##########
.github/CODEOWNERS:
##########
@@ -0,0 +1,54 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+# Any committer can add themselves to any of the path patterns
+# and will subsequently get requested as a reviewer for any PRs
+# that change matching files.
+#
+# This file uses .gitignore syntax with a few exceptions see the
+# documentation about the syntax: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
+
+## Format
+adbc.h @lidavidm
+
+## Implementations
+/c/ @lidavidm @WillAyd
+/csharp/ @CurtHagenlocher @davidhcoe
Review Comment:
@WillAyd I tagged you in a comment, and then deleted that comment after @lidavidm mentioned that it wouldn't work. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm merged pull request #829: ci: Add CODEOWNERS file
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #829:
URL: https://github.com/apache/arrow-adbc/pull/829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on a diff in pull request #829: ci: Add CODEOWNERS file
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #829:
URL: https://github.com/apache/arrow-adbc/pull/829#discussion_r1237205221
##########
.github/CODEOWNERS:
##########
@@ -0,0 +1,54 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+# Any committer can add themselves to any of the path patterns
+# and will subsequently get requested as a reviewer for any PRs
+# that change matching files.
+#
+# This file uses .gitignore syntax with a few exceptions see the
+# documentation about the syntax: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
+
+## Format
+adbc.h @lidavidm
+
+## Implementations
+/c/ @lidavidm @WillAyd
+/csharp/ @CurtHagenlocher @davidhcoe
Review Comment:
...For now, sure. I guess I should go re-learn C♯ at this rate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] zeroshade commented on a diff in pull request #829: ci: Add CODEOWNERS file
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #829:
URL: https://github.com/apache/arrow-adbc/pull/829#discussion_r1237198798
##########
.github/CODEOWNERS:
##########
@@ -0,0 +1,54 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+# Any committer can add themselves to any of the path patterns
+# and will subsequently get requested as a reviewer for any PRs
+# that change matching files.
+#
+# This file uses .gitignore syntax with a few exceptions see the
+# documentation about the syntax: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
+
+## Format
+adbc.h @lidavidm
+
+## Implementations
+/c/ @lidavidm @WillAyd
+/csharp/ @CurtHagenlocher @davidhcoe
Review Comment:
darn oh well. Should I put you as the codeowner for the csharp? Or leave it commented out for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on a diff in pull request #829: ci: Add CODEOWNERS file
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #829:
URL: https://github.com/apache/arrow-adbc/pull/829#discussion_r1237153877
##########
.github/CODEOWNERS:
##########
@@ -0,0 +1,54 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+# Any committer can add themselves to any of the path patterns
+# and will subsequently get requested as a reviewer for any PRs
+# that change matching files.
+#
+# This file uses .gitignore syntax with a few exceptions see the
+# documentation about the syntax: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
+
+## Format
+adbc.h @lidavidm
+
+## Implementations
+/c/ @lidavidm @WillAyd
+/csharp/ @CurtHagenlocher @davidhcoe
Review Comment:
You need write access to be a codeowner, so this won't work unfortunately.
##########
.github/CODEOWNERS:
##########
@@ -0,0 +1,54 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+# Any committer can add themselves to any of the path patterns
+# and will subsequently get requested as a reviewer for any PRs
+# that change matching files.
+#
+# This file uses .gitignore syntax with a few exceptions see the
+# documentation about the syntax: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
+
+## Format
+adbc.h @lidavidm
+
+## Implementations
+/c/ @lidavidm @WillAyd
+/csharp/ @CurtHagenlocher @davidhcoe
+/glib/ @kou
+/java/ @lidavidm
+/go/ @zeroshade
+/python/ @lidavidm
+/r/ @paleolimbot
+/ruby/ @kou
+/rust/ @wjones127
+
+## Docs
+# /docs/
Review Comment:
```suggestion
/docs/ @lidavidm
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org