You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2018/03/14 23:31:05 UTC

[Impala-ASF-CR] IMPALA-6669: Remove Parquet NeedsSeedingForBatchedReading()

Tim Armstrong has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9636 )

Change subject: IMPALA-6669: Remove Parquet NeedsSeedingForBatchedReading()
......................................................................

IMPALA-6669: Remove Parquet NeedsSeedingForBatchedReading()

I noticed that we could remove this part of the interface and instead
do the "seeding" in ParquetColumnReader::Read*ValueBatch(). It should
be easier to understand with level reading and consumption happening
driven by the same function instead of split between files.

Testing:
Ran core tests. This code path should be thoroughly exercised by
the regular scanner tests.

Change-Id: I98f65d0d72e86b1e3db1f3543a03873afb9da062
---
M be/src/exec/hdfs-parquet-scanner.cc
M be/src/exec/parquet-column-readers.cc
M be/src/exec/parquet-column-readers.h
3 files changed, 20 insertions(+), 41 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/9636/2
-- 
To view, visit http://gerrit.cloudera.org:8080/9636
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I98f65d0d72e86b1e3db1f3543a03873afb9da062
Gerrit-Change-Number: 9636
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>